Issue python#29368: Fix _Pickle_FastCall() usage in do_append()

vstinner · vstinner · commit fd6d0d2a18bb · 2017-02-02T10:56:47.000+01:00
_Pickle_FastCall() has a surprising API: it decrements the reference counter of
its second argument.
diff --git a/Modules/_pickle.c b/Modules/_pickle.c
@@ -5844,7 +5844,6 @@ do_append(UnpicklerObject *self, Py_ssize_t x)
                 return -1;
             }
             result = _Pickle_FastCall(extend_func, slice);
-            Py_DECREF(slice);
             Py_DECREF(extend_func);
             if (result == NULL)
                 return -1;

Original file line number	Diff line number	Diff line change
`@@ -5844,7 +5844,6 @@ do_append(UnpicklerObject *self, Py_ssize_t x)`
`5844`	`5844`	`return -1;`
`5845`	`5845`	`}`
`5846`	`5846`	`result = _Pickle_FastCall(extend_func, slice);`
`5847`		`- Py_DECREF(slice);`
`5848`	`5847`	`Py_DECREF(extend_func);`
`5849`	`5848`	`if (result == NULL)`
`5850`	`5849`	`return -1;`