Silence expression result unused warnings with clang.

tiran · tiran · commit d3afe781b15e · 2013-12-04T09:27:47.000+01:00
The PyObject_INIT() macros returns obj:

../cpython/Objects/methodobject.c:32:23: warning: expression result unused [-Wunused-value]
        PyObject_INIT(op, &amp;PyCFunction_Type);
                      ^~
../cpython/Include/objimpl.h:139:69: note: expanded from macro 'PyObject_INIT'
    ( Py_TYPE(op) = (typeobj), _Py_NewReference((PyObject *)(op)), (op) )
                                                                    ^
1 warning generated.
diff --git a/Objects/bytesobject.c b/Objects/bytesobject.c
@@ -107,7 +107,7 @@ PyBytes_FromStringAndSize(const char *str, Py_ssize_t size)
     op = (PyBytesObject *)PyObject_MALLOC(PyBytesObject_SIZE + size);
     if (op == NULL)
         return PyErr_NoMemory();
-    PyObject_INIT_VAR(op, &PyBytes_Type, size);
+    (void)PyObject_INIT_VAR(op, &PyBytes_Type, size);
     op->ob_shash = -1;
     if (str != NULL)
         Py_MEMCPY(op->ob_sval, str, size);
@@ -155,7 +155,7 @@ PyBytes_FromString(const char *str)
     op = (PyBytesObject *)PyObject_MALLOC(PyBytesObject_SIZE + size);
     if (op == NULL)
         return PyErr_NoMemory();
-    PyObject_INIT_VAR(op, &PyBytes_Type, size);
+    (void)PyObject_INIT_VAR(op, &PyBytes_Type, size);
     op->ob_shash = -1;
     Py_MEMCPY(op->ob_sval, str, size+1);
     /* share short strings */
@@ -749,7 +749,7 @@ bytes_repeat(PyBytesObject *a, Py_ssize_t n)
     op = (PyBytesObject *)PyObject_MALLOC(PyBytesObject_SIZE + nbytes);
     if (op == NULL)
         return PyErr_NoMemory();
-    PyObject_INIT_VAR(op, &PyBytes_Type, size);
+    (void)PyObject_INIT_VAR(op, &PyBytes_Type, size);
     op->ob_shash = -1;
     op->ob_sval[size] = '\0';
     if (Py_SIZE(a) == 1 && n > 0) {
diff --git a/Objects/classobject.c b/Objects/classobject.c
@@ -52,7 +52,7 @@ PyMethod_New(PyObject *func, PyObject *self)
     im = free_list;
     if (im != NULL) {
         free_list = (PyMethodObject *)(im->im_self);
-        PyObject_INIT(im, &PyMethod_Type);
+        (void)PyObject_INIT(im, &PyMethod_Type);
         numfree--;
     }
     else {
diff --git a/Objects/complexobject.c b/Objects/complexobject.c
@@ -217,7 +217,7 @@ PyComplex_FromCComplex(Py_complex cval)
     op = (PyComplexObject *) PyObject_MALLOC(sizeof(PyComplexObject));
     if (op == NULL)
         return PyErr_NoMemory();
-    PyObject_INIT(op, &PyComplex_Type);
+    (void)PyObject_INIT(op, &PyComplex_Type);
     op->cval = cval;
     return (PyObject *) op;
 }
diff --git a/Objects/floatobject.c b/Objects/floatobject.c
@@ -119,7 +119,7 @@ PyFloat_FromDouble(double fval)
             return PyErr_NoMemory();
     }
     /* Inline PyObject_New */
-    PyObject_INIT(op, &PyFloat_Type);
+    (void)PyObject_INIT(op, &PyFloat_Type);
     op->ob_fval = fval;
     return (PyObject *) op;
 }
diff --git a/Objects/longobject.c b/Objects/longobject.c
@@ -5089,7 +5089,7 @@ _PyLong_Init(void)
             assert(v->ob_digit[0] == abs(ival));
         }
         else {
-            PyObject_INIT(v, &PyLong_Type);
+            (void)PyObject_INIT(v, &PyLong_Type);
         }
         Py_SIZE(v) = size;
         v->ob_digit[0] = abs(ival);
diff --git a/Objects/methodobject.c b/Objects/methodobject.c
@@ -29,7 +29,7 @@ PyCFunction_NewEx(PyMethodDef *ml, PyObject *self, PyObject *module)
     op = free_list;
     if (op != NULL) {
         free_list = (PyCFunctionObject *)(op->m_self);
-        PyObject_INIT(op, &PyCFunction_Type);
+        (void)PyObject_INIT(op, &PyCFunction_Type);
         numfree--;
     }
     else {
diff --git a/Objects/typeobject.c b/Objects/typeobject.c
@@ -787,7 +787,7 @@ PyType_GenericAlloc(PyTypeObject *type, Py_ssize_t nitems)
         Py_INCREF(type);
 
     if (type->tp_itemsize == 0)
-        PyObject_INIT(obj, type);
+        (void)PyObject_INIT(obj, type);
     else
         (void) PyObject_INIT_VAR((PyVarObject *)obj, type, nitems);
 

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ PyMethod_New(PyObject func, PyObject self)`
`52`	`52`	`im = free_list;`
`53`	`53`	`if (im != NULL) {`
`54`	`54`	`free_list = (PyMethodObject *)(im->im_self);`
`55`		`- PyObject_INIT(im, &PyMethod_Type);`
	`55`	`+ (void)PyObject_INIT(im, &PyMethod_Type);`
`56`	`56`	`numfree--;`
`57`	`57`	`}`
`58`	`58`	`else {`
Original file line number	Diff line number	Diff line change
`@@ -217,7 +217,7 @@ PyComplex_FromCComplex(Py_complex cval)`
`217`	`217`	`op = (PyComplexObject *) PyObject_MALLOC(sizeof(PyComplexObject));`
`218`	`218`	`if (op == NULL)`
`219`	`219`	`return PyErr_NoMemory();`
`220`		`- PyObject_INIT(op, &PyComplex_Type);`
	`220`	`+ (void)PyObject_INIT(op, &PyComplex_Type);`
`221`	`221`	`op->cval = cval;`
`222`	`222`	`return (PyObject *) op;`
`223`	`223`	`}`
Original file line number	Diff line number	Diff line change
`@@ -119,7 +119,7 @@ PyFloat_FromDouble(double fval)`
`119`	`119`	`return PyErr_NoMemory();`
`120`	`120`	`}`
`121`	`121`	`/* Inline PyObject_New */`
`122`		`- PyObject_INIT(op, &PyFloat_Type);`
	`122`	`+ (void)PyObject_INIT(op, &PyFloat_Type);`
`123`	`123`	`op->ob_fval = fval;`
`124`	`124`	`return (PyObject *) op;`
`125`	`125`	`}`
Original file line number	Diff line number	Diff line change
`@@ -5089,7 +5089,7 @@ _PyLong_Init(void)`
`5089`	`5089`	`assert(v->ob_digit[0] == abs(ival));`
`5090`	`5090`	`}`
`5091`	`5091`	`else {`
`5092`		`- PyObject_INIT(v, &PyLong_Type);`
	`5092`	`+ (void)PyObject_INIT(v, &PyLong_Type);`
`5093`	`5093`	`}`
`5094`	`5094`	`Py_SIZE(v) = size;`
`5095`	`5095`	`v->ob_digit[0] = abs(ival);`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ PyCFunction_NewEx(PyMethodDef ml, PyObject self, PyObject *module)`
`29`	`29`	`op = free_list;`
`30`	`30`	`if (op != NULL) {`
`31`	`31`	`free_list = (PyCFunctionObject *)(op->m_self);`
`32`		`- PyObject_INIT(op, &PyCFunction_Type);`
	`32`	`+ (void)PyObject_INIT(op, &PyCFunction_Type);`
`33`	`33`	`numfree--;`
`34`	`34`	`}`
`35`	`35`	`else {`