Skip to content

Commit a394f2d

Browse files
committed
python#4351: more appropriate DeprecationWarning stacklevels
1 parent e7d149e commit a394f2d

4 files changed

Lines changed: 9 additions & 9 deletions

File tree

Lib/cgi.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,13 +163,13 @@ def parse(fp=None, environ=os.environ, keep_blank_values=0, strict_parsing=0):
163163
def parse_qs(qs, keep_blank_values=0, strict_parsing=0):
164164
"""Parse a query given as a string argument."""
165165
warn("cgi.parse_qs is deprecated, use urllib.parse.parse_qs instead",
166-
DeprecationWarning)
166+
DeprecationWarning, 2)
167167
return urllib.parse.parse_qs(qs, keep_blank_values, strict_parsing)
168168

169169
def parse_qsl(qs, keep_blank_values=0, strict_parsing=0):
170170
"""Parse a query given as a string argument."""
171171
warn("cgi.parse_qsl is deprecated, use urllib.parse.parse_qsl instead",
172-
DeprecationWarning)
172+
DeprecationWarning, 2)
173173
return urllib.parse.parse_qsl(qs, keep_blank_values, strict_parsing)
174174

175175
def parse_multipart(fp, pdict):

Lib/gzip.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ def __init__(self, filename=None, mode=None,
136136
@property
137137
def filename(self):
138138
import warnings
139-
warnings.warn("use the name attribute", DeprecationWarning)
139+
warnings.warn("use the name attribute", DeprecationWarning, 2)
140140
if self.mode == WRITE and self.name[-3:] != ".gz":
141141
return self.name + ".gz"
142142
return self.name

Lib/plistlib.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -263,13 +263,13 @@ def __getattr__(self, attr):
263263
raise AttributeError(attr)
264264
from warnings import warn
265265
warn("Attribute access from plist dicts is deprecated, use d[key] "
266-
"notation instead", PendingDeprecationWarning)
266+
"notation instead", PendingDeprecationWarning, 2)
267267
return value
268268

269269
def __setattr__(self, attr, value):
270270
from warnings import warn
271271
warn("Attribute access from plist dicts is deprecated, use d[key] "
272-
"notation instead", PendingDeprecationWarning)
272+
"notation instead", PendingDeprecationWarning, 2)
273273
self[attr] = value
274274

275275
def __delattr__(self, attr):
@@ -279,14 +279,14 @@ def __delattr__(self, attr):
279279
raise AttributeError(attr)
280280
from warnings import warn
281281
warn("Attribute access from plist dicts is deprecated, use d[key] "
282-
"notation instead", PendingDeprecationWarning)
282+
"notation instead", PendingDeprecationWarning, 2)
283283

284284
class Dict(_InternalDict):
285285

286286
def __init__(self, **kwargs):
287287
from warnings import warn
288288
warn("The plistlib.Dict class is deprecated, use builtin dict instead",
289-
PendingDeprecationWarning)
289+
PendingDeprecationWarning, 2)
290290
super().__init__(**kwargs)
291291

292292

@@ -299,7 +299,7 @@ class Plist(_InternalDict):
299299
def __init__(self, **kwargs):
300300
from warnings import warn
301301
warn("The Plist class is deprecated, use the readPlist() and "
302-
"writePlist() functions instead", PendingDeprecationWarning)
302+
"writePlist() functions instead", PendingDeprecationWarning, 2)
303303
super().__init__(**kwargs)
304304

305305
def fromFile(cls, pathOrFile):

Lib/string.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ def maketrans(frm: bytes, to: bytes) -> bytes:
5151
"""
5252
import warnings
5353
warnings.warn("string.maketrans is deprecated, use bytes.maketrans instead",
54-
DeprecationWarning)
54+
DeprecationWarning, 2)
5555
if len(frm) != len(to):
5656
raise ValueError("maketrans arguments must have same length")
5757
if not (isinstance(frm, bytes) and isinstance(to, bytes)):

0 commit comments

Comments
 (0)