Skip to content

Commit a27244b

Browse files
Added a warning filter to don't show the warning during
the tests. Also fixed the warning message in cgi.py
1 parent 1cd0247 commit a27244b

2 files changed

Lines changed: 14 additions & 5 deletions

File tree

Lib/cgi.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ def parse_qs(qs, keep_blank_values=0, strict_parsing=0):
168168

169169
def parse_qsl(qs, keep_blank_values=0, strict_parsing=0):
170170
"""Parse a query given as a string argument."""
171-
warn("cgi.parse_qsl is deprecated, use urllib.parse.parse_qs instead",
171+
warn("cgi.parse_qsl is deprecated, use urllib.parse.parse_qsl instead",
172172
DeprecationWarning)
173173
return urllib.parse.parse_qsl(qs, keep_blank_values, strict_parsing)
174174

Lib/test/test_cgi.py

Lines changed: 13 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import tempfile
66
import unittest
77
from io import StringIO
8+
from warnings import catch_warnings, filterwarnings
89

910
class HackedSysModule:
1011
# The regression test will have real values in sys.argv, which
@@ -308,13 +309,21 @@ def testQSAndFormDataFile(self):
308309

309310
def test_deprecated_parse_qs(self):
310311
# this func is moved to urlparse, this is just a sanity check
311-
self.assertEqual({'a': ['A1'], 'B': ['B3'], 'b': ['B2']},
312-
cgi.parse_qs('a=A1&b=B2&B=B3'))
312+
with catch_warnings():
313+
filterwarnings('ignore',
314+
'cgi.parse_qs is deprecated, use urllib.parse.parse_qs instead',
315+
DeprecationWarning)
316+
self.assertEqual({'a': ['A1'], 'B': ['B3'], 'b': ['B2']},
317+
cgi.parse_qs('a=A1&b=B2&B=B3'))
313318

314319
def test_deprecated_parse_qsl(self):
315320
# this func is moved to urlparse, this is just a sanity check
316-
self.assertEqual([('a', 'A1'), ('b', 'B2'), ('B', 'B3')],
317-
cgi.parse_qsl('a=A1&b=B2&B=B3'))
321+
with catch_warnings():
322+
filterwarnings('ignore',
323+
'cgi.parse_qsl is deprecated, use urllib.parse.parse_qsl instead',
324+
DeprecationWarning)
325+
self.assertEqual([('a', 'A1'), ('b', 'B2'), ('B', 'B3')],
326+
cgi.parse_qsl('a=A1&b=B2&B=B3'))
318327

319328
def test_main():
320329
run_unittest(CgiTests)

0 commit comments

Comments
 (0)