Skip to content

Commit 3bb9020

Browse files
adchiaadchia
authored
ci: Add extra validation in release process dry runs (feast-dev#3321)
* ci: Add extra validation in release process dry runs Signed-off-by: Danny Chiao <danny@tecton.ai> * remove file bump Signed-off-by: Danny Chiao <danny@tecton.ai> Signed-off-by: Danny Chiao <danny@tecton.ai>
1 parent 5956981 commit 3bb9020

12 files changed

Lines changed: 44 additions & 307 deletions

File tree

‎.github/workflows/release.yml‎

Lines changed: 44 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,53 @@ jobs:
4242
echo "Current version is ${CURRENT_VERSION}"
4343
echo "Next version is ${NEXT_VERSION}"
4444
45-
publish-web-ui-npm:
45+
validate_version_bumps:
4646
if: github.repository == 'feast-dev/feast'
4747
needs: get_dry_release_versions
4848
runs-on: ubuntu-latest
49+
env:
50+
# This publish is working using an NPM automation token to bypass 2FA
51+
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
52+
HELM_VERSION: v3.8.0
53+
CURRENT_VERSION: ${{ needs.get_dry_release_versions.outputs.current_version }}
54+
NEXT_VERSION: ${{ needs.get_dry_release_versions.outputs.next_version }}
55+
steps:
56+
- uses: actions/checkout@v2
57+
- uses: actions/setup-node@v2
58+
with:
59+
node-version: '17.x'
60+
registry-url: 'https://registry.npmjs.org'
61+
- name: Bump file versions
62+
run: python ./infra/scripts/release/bump_file_versions.py ${CURRENT_VERSION} ${NEXT_VERSION}
63+
- name: Install yarn dependencies
64+
working-directory: ./ui
65+
run: yarn install
66+
- name: Build yarn rollup
67+
working-directory: ./ui
68+
run: yarn build:lib
69+
- name: Bundle UI in SDK
70+
run: make build-ui
71+
- name: Remove previous Helm
72+
run: sudo rm -rf $(which helm)
73+
- name: Set up Homebrew
74+
uses: Homebrew/actions/setup-homebrew@master
75+
- name: Setup Helm-docs
76+
run: |
77+
brew install norwoodj/tap/helm-docs
78+
- name: Generate helm chart READMEs
79+
run: make build-helm-docs
80+
- name: Install Helm
81+
run: ./infra/scripts/helm/install-helm.sh
82+
- name: Validate Helm chart prior to publishing
83+
run: ./infra/scripts/helm/validate-helm-chart-publish.sh
84+
- name: Validate all version consistency
85+
run: ./infra/scripts/helm/validate-helm-chart-versions.sh $NEXT_VERSION
86+
87+
88+
publish-web-ui-npm:
89+
if: github.repository == 'feast-dev/feast'
90+
needs: validate_version_bumps
91+
runs-on: ubuntu-latest
4992
env:
5093
# This publish is working using an NPM automation token to bypass 2FA
5194
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

‎Makefile‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -461,7 +461,6 @@ build-templates:
461461
build-helm-docs:
462462
cd ${ROOT_DIR}/infra/charts/feast; helm-docs
463463
cd ${ROOT_DIR}/infra/charts/feast-feature-server; helm-docs
464-
cd ${ROOT_DIR}/infra/charts/feast-python-server; helm-docs
465464

466465
# Web UI
467466

‎infra/charts/feast-python-server/.helmignore‎

Lines changed: 0 additions & 23 deletions
This file was deleted.

‎infra/charts/feast-python-server/Chart.yaml‎

Lines changed: 0 additions & 12 deletions
This file was deleted.

‎infra/charts/feast-python-server/README.md‎

Lines changed: 0 additions & 50 deletions
This file was deleted.

‎infra/charts/feast-python-server/README.md.gotmpl‎

Lines changed: 0 additions & 29 deletions
This file was deleted.

‎infra/charts/feast-python-server/templates/_helpers.tpl‎

Lines changed: 0 additions & 52 deletions
This file was deleted.

‎infra/charts/feast-python-server/templates/deployment.yaml‎

Lines changed: 0 additions & 61 deletions
This file was deleted.

‎infra/charts/feast-python-server/templates/service.yaml‎

Lines changed: 0 additions & 15 deletions
This file was deleted.

‎infra/charts/feast-python-server/values.yaml‎

Lines changed: 0 additions & 59 deletions
This file was deleted.

0 commit comments

Comments
 (0)