Added check for "Buffer", needs more work to deduplicate code, a

rubendel · rubendel · commit 74b42a77f264 · 2020-01-30T16:33:27.000+01:00
namespace for the schemas would be even better.
diff --git a/bimserverclient.js b/bimserverclient.js
@@ -778,7 +778,9 @@ export class BimServerClient {
 		}
 
 		let subject = this.schemas[schema][typeSubject];
-		if (typeSubject == "GeometryInfo" || typeSubject == "GeometryData") {
+
+		// TODO duplicate code (also twice in model.js)
+		if (typeSubject === "GeometryInfo" || typeSubject === "GeometryData" || typeSubject === "Buffer") {
 			subject = this.schemas.geometry[typeSubject];
 		}
 
diff --git a/model.js b/model.js
@@ -151,7 +151,7 @@ export class Model {
 
 	extendClass(wrapperClass, typeName) {
 		let realType = this.bimServerApi.schemas[this.schema][typeName];
-		if (typeName === "GeometryInfo" || typeName === "GeometryData") {
+		if (typeName === "GeometryInfo" || typeName === "GeometryData" || typeName === "Buffer") {
 			realType = this.bimServerApi.schemas.geometry[typeName];
 		}
 		realType.superclasses.forEach((typeName) => {
@@ -454,7 +454,7 @@ export class Model {
 		if (this.bimServerApi.classes[typeName] == null) {
 			let realType = this.bimServerApi.schemas[this.schema][typeName];
 			if (realType == null) {
-				if (typeName === "GeometryInfo" || typeName === "GeometryData") {
+				if (typeName === "GeometryInfo" || typeName === "GeometryData" || typeName === "Buffer") {
 					realType = this.bimServerApi.schemas.geometry[typeName];
 				}
 				if (realType == null) {

Original file line number	Diff line number	Diff line change
`@@ -778,7 +778,9 @@ export class BimServerClient {`
`778`	`778`	`}`
`779`	`779`
`780`	`780`	`let subject = this.schemas[schema][typeSubject];`
`781`		`- if (typeSubject == "GeometryInfo" \|\| typeSubject == "GeometryData") {`
	`781`	`+`
	`782`	`+ // TODO duplicate code (also twice in model.js)`
	`783`	`+ if (typeSubject === "GeometryInfo" \|\| typeSubject === "GeometryData" \|\| typeSubject === "Buffer") {`
`782`	`784`	`subject = this.schemas.geometry[typeSubject];`
`783`	`785`	`}`
`784`	`786`