Skip to content

Commit 80af02e

Browse files
committed
syntax error fixes
1 parent 0f1c35c commit 80af02e

File tree

6 files changed

+13
-11
lines changed

6 files changed

+13
-11
lines changed

jme3-core/src/main/java/com/jme3/material/DefaultTechniqueDefLogic.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public DefaultTechniqueDefLogic(TechniqueDef techniqueDef) {
5656

5757
@Override
5858
public Shader makeCurrent(AssetManager assetManager, RenderManager renderManager,
59-
EnumSet<Caps> rendererCaps, DefineList defines) {
59+
EnumSet<Caps> rendererCaps, LightList lights, DefineList defines) {
6060
return techniqueDef.getShader(assetManager, rendererCaps, defines);
6161
}
6262

jme3-core/src/main/java/com/jme3/material/Material.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -834,7 +834,7 @@ public void preload(RenderManager renderManager) {
834834
return;
835835
}
836836

837-
Shader shader = technique.makeCurrent(renderManager, rendererCaps);
837+
Shader shader = technique.makeCurrent(renderManager, null, rendererCaps);
838838
updateShaderMaterialParameters(renderer, shader);
839839
renderManager.getRenderer().setShader(shader);
840840
}
@@ -939,7 +939,7 @@ public void render(Geometry geometry, LightList lights, RenderManager renderMana
939939
updateRenderState(renderManager, renderer, techniqueDef);
940940

941941
// Select shader to use
942-
Shader shader = technique.makeCurrent(renderManager, rendererCaps);
942+
Shader shader = technique.makeCurrent(renderManager, lights, rendererCaps);
943943

944944
// Begin tracking which uniforms were changed by material.
945945
clearUniformsSetByCurrent(shader);

jme3-core/src/main/java/com/jme3/material/SinglePassLightingLogic.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,10 +76,10 @@ public SinglePassLightingLogic(TechniqueDef techniqueDef) {
7676

7777
@Override
7878
public Shader makeCurrent(AssetManager assetManager, RenderManager renderManager,
79-
EnumSet<Caps> rendererCaps, DefineList defines) {
79+
EnumSet<Caps> rendererCaps, LightList lights, DefineList defines) {
8080
defines.set(nbLightsDefineId, renderManager.getSinglePassLightBatchSize() * 3);
8181
defines.set(singlePassLightingDefineId, true);
82-
return super.makeCurrent(assetManager, renderManager, rendererCaps, defines);
82+
return super.makeCurrent(assetManager, renderManager, rendererCaps, lights, defines);
8383
}
8484

8585
/**

jme3-core/src/main/java/com/jme3/material/Technique.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,10 +131,10 @@ void notifyTechniqueSwitched() {
131131
* @param rendererCaps The renderer capabilities which the shader should support.
132132
* @return A compatible shader.
133133
*/
134-
Shader makeCurrent(RenderManager renderManager, EnumSet<Caps> rendererCaps) {
134+
Shader makeCurrent(RenderManager renderManager, LightList lights, EnumSet<Caps> rendererCaps) {
135135
TechniqueDefLogic logic = def.getLogic();
136136
AssetManager assetManager = owner.getMaterialDef().getAssetManager();
137-
return logic.makeCurrent(assetManager, renderManager, rendererCaps, dynamicDefines);
137+
return logic.makeCurrent(assetManager, renderManager, rendererCaps, lights, dynamicDefines);
138138
}
139139

140140
/**

jme3-core/src/main/java/com/jme3/material/TechniqueDefLogic.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,14 +66,16 @@ public interface TechniqueDefLogic {
6666
* @param renderManager The render manager for which rendering is to be performed.
6767
* @param rendererCaps Renderer capabilities. The returned shader must
6868
* support these capabilities.
69+
* @param lights The lights with which the geometry shall be rendered. This
70+
* list must not include culled lights.
6971
* @param defines The define list used by the technique, any
7072
* {@link TechniqueDef#addShaderUnmappedDefine(java.lang.String) unmapped defines}
7173
* should be set here to change shader behavior.
7274
*
7375
* @return The shader to use for rendering.
7476
*/
7577
public Shader makeCurrent(AssetManager assetManager, RenderManager renderManager,
76-
EnumSet<Caps> rendererCaps, DefineList defines);
78+
EnumSet<Caps> rendererCaps, LightList lights, DefineList defines);
7779

7880
/**
7981
* Requests that the <code>TechniqueDefLogic</code> renders the given geometry.

jme3-core/src/main/java/com/jme3/renderer/RenderManager.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
import com.jme3.renderer.queue.RenderQueue.Bucket;
5050
import com.jme3.renderer.queue.RenderQueue.ShadowMode;
5151
import com.jme3.scene.*;
52-
import com.jme3.shader.Uniform;
52+
import com.jme3.shader.Shader;
5353
import com.jme3.shader.UniformBinding;
5454
import com.jme3.shader.UniformBindingManager;
5555
import com.jme3.system.NullRenderer;
@@ -483,8 +483,8 @@ public void setWorldMatrix(Matrix4f mat) {
483483
* Updates the given list of uniforms with {@link UniformBinding uniform bindings}
484484
* based on the current world state.
485485
*/
486-
public void updateUniformBindings(List<Uniform> params) {
487-
uniformBindingManager.updateUniformBindings(params);
486+
public void updateUniformBindings(Shader shader) {
487+
uniformBindingManager.updateUniformBindings(shader);
488488
}
489489

490490
/**

0 commit comments

Comments
 (0)