Add failing test case for missing fragment name

corydolphin · corydolphin · commit b3842cc7cd58 · 2017-04-28T11:48:22.000-07:00
diff --git a/src/main/java/graphql/validation/RulesVisitor.java b/src/main/java/graphql/validation/RulesVisitor.java
@@ -112,7 +112,7 @@ private void checkFragmentSpread(FragmentSpread fragmentSpread, List<AbstractRul
         List<AbstractRule> rulesVisitingFragmentSpreads = getRulesVisitingFragmentSpreads(rules);
         if (rulesVisitingFragmentSpreads.size() > 0) {
             FragmentDefinition fragment = validationContext.getFragment(fragmentSpread.getName());
-            if(!ancestors.contains(fragment)){
+            if (fragment != null && !ancestors.contains(fragment)) {
                 new LanguageTraversal(ancestors).traverse(fragment, new RulesVisitor(validationContext, rulesVisitingFragmentSpreads, true));
             }
         }
diff --git a/src/main/java/graphql/validation/rules/NoUnusedFragments.java b/src/main/java/graphql/validation/rules/NoUnusedFragments.java
@@ -67,6 +67,9 @@ private void collectUsedFragmentsInDefinition(List<String> result, String fragme
         if (result.contains(fragmentName)) return;
         result.add(fragmentName);
         List<String> spreadList = spreadsInDefinition.get(fragmentName);
+        if (spreadList == null) {
+            return;
+        }
         for (String fragment : spreadList) {
             collectUsedFragmentsInDefinition(result, fragment);
         }
diff --git a/src/test/groovy/graphql/validation/RulesVisitorTest.groovy b/src/test/groovy/graphql/validation/RulesVisitorTest.groovy
@@ -3,7 +3,6 @@ package graphql.validation
 import graphql.TestUtil
 import graphql.language.Document
 import graphql.parser.Parser
-import graphql.validation.rules.NoFragmentCycles
 import graphql.validation.rules.NoUnusedVariables
 import spock.lang.Specification
 
diff --git a/src/test/groovy/graphql/validation/SpecValidation5421Test.groovy b/src/test/groovy/graphql/validation/SpecValidation5421Test.groovy
@@ -0,0 +1,26 @@
+package graphql.validation
+/**
+ * validation examples used in the spec in given section
+ * http://facebook.github.io/graphql/#sec-Validation
+ * @author dwinsor
+ *        
+ */
+class SpecValidation5421Test extends SpecValidationBase {
+
+    def '5.4.2.1 Fragment spread target defined '() {
+        def query = """
+            query getDogName {
+              dog {
+                ... FragmentDoesNotExist
+              }           
+            }
+        """
+        when:
+        def validationErrors = validate(query)
+
+        then:
+        !validationErrors.empty
+        validationErrors.size() == 1
+        validationErrors.get(0).getValidationErrorType() == ValidationErrorType.UndefinedFragment
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ private void checkFragmentSpread(FragmentSpread fragmentSpread, List<AbstractRul`
`112`	`112`	`List<AbstractRule> rulesVisitingFragmentSpreads = getRulesVisitingFragmentSpreads(rules);`
`113`	`113`	`if (rulesVisitingFragmentSpreads.size() > 0) {`
`114`	`114`	`FragmentDefinition fragment = validationContext.getFragment(fragmentSpread.getName());`
`115`		`- if(!ancestors.contains(fragment)){`
	`115`	`+ if (fragment != null && !ancestors.contains(fragment)) {`
`116`	`116`	`new LanguageTraversal(ancestors).traverse(fragment, new RulesVisitor(validationContext, rulesVisitingFragmentSpreads, true));`
`117`	`117`	`}`
`118`	`118`	`}`