more tests

andimarek · andimarek · commit 42dc1be34a78 · 2018-03-17T21:14:04.000+11:00
diff --git a/src/main/java/graphql/language/NodeVisitor.java b/src/main/java/graphql/language/NodeVisitor.java
@@ -1,8 +1,10 @@
 package graphql.language;
 
+import graphql.Internal;
 import graphql.util.TraversalControl;
 import graphql.util.TraverserContext;
 
+@Internal
 public interface NodeVisitor {
     TraversalControl visitArgument(Argument node, TraverserContext<Node> data);
 
diff --git a/src/main/java/graphql/language/NodeVisitorStub.java b/src/main/java/graphql/language/NodeVisitorStub.java
@@ -1,9 +1,11 @@
 package graphql.language;
 
+import graphql.Internal;
 import graphql.util.TraversalControl;
 import graphql.util.TraverserContext;
 
-public abstract class NodeVisitorStub
+@Internal
+public class NodeVisitorStub
         implements NodeVisitor {
     @Override
     public TraversalControl visitArgument(Argument node, TraverserContext<Node> context) {
diff --git a/src/main/java/graphql/util/SimpleTraverserContext.java b/src/main/java/graphql/util/SimpleTraverserContext.java
@@ -1,9 +1,12 @@
 package graphql.util;
 
+import graphql.Internal;
+
 import java.util.LinkedHashMap;
 import java.util.Map;
 import java.util.Set;
 
+@Internal
 public class SimpleTraverserContext<T> implements TraverserContext<T> {
 
     private final Map<Class<?>, Object> vars = new LinkedHashMap<>();
diff --git a/src/main/java/graphql/util/TraverserVisitor.java b/src/main/java/graphql/util/TraverserVisitor.java
@@ -7,8 +7,14 @@ public interface TraverserVisitor<T> {
 
     TraversalControl enter(TraverserContext<T> context);
 
+    /**
+     * @return Only Continue or Quit allowed
+     */
     TraversalControl leave(TraverserContext<T> context);
 
+    /**
+     * @return Only Continue or Quit allowed
+     */
     default TraversalControl backRef(TraverserContext<T> context) {
         return TraversalControl.CONTINUE;
     }
diff --git a/src/test/groovy/graphql/language/NodeVisitorStubTest.groovy b/src/test/groovy/graphql/language/NodeVisitorStubTest.groovy
@@ -0,0 +1,41 @@
+package graphql.language
+
+import graphql.util.TraversalControl
+import graphql.util.TraverserContext
+import spock.lang.Specification
+
+class NodeVisitorStubTest extends Specification {
+
+
+    def "selection nodes call visitSelection by default"() {
+        given:
+        NodeVisitorStub nodeVisitorStub = Spy(NodeVisitorStub, constructorArgs: [])
+        Field field = new Field()
+        FragmentSpread fragmentSpread = new FragmentSpread()
+        InlineFragment inlineFragment = new InlineFragment()
+        TraverserContext context = Mock(TraverserContext)
+
+        when:
+        def control = nodeVisitorStub.visitField(field, context)
+
+        then:
+        1 * nodeVisitorStub.visitSelection(field, context) >> TraversalControl.QUIT
+        control == TraversalControl.QUIT
+
+        when:
+        control = nodeVisitorStub.visitInlineFragment(inlineFragment, context)
+
+        then:
+        1 * nodeVisitorStub.visitSelection(inlineFragment, context) >> TraversalControl.QUIT
+        control == TraversalControl.QUIT
+
+        when:
+        control = nodeVisitorStub.visitFragmentSpread(fragmentSpread, context)
+
+        then:
+        1 * nodeVisitorStub.visitSelection(fragmentSpread, context) >> TraversalControl.QUIT
+        control == TraversalControl.QUIT
+    }
+
+    // TODO: more testing
+}
