mapstruct#883 Simplifying look-up of test locale

gunnarmorling · gunnarmorling · commit aae152735258 · 2017-07-07T17:52:20.000+02:00
diff --git a/processor/src/test/java/org/mapstruct/ap/internal/util/StringsTest.java b/processor/src/test/java/org/mapstruct/ap/internal/util/StringsTest.java
@@ -157,13 +157,12 @@ public void decapitalizeTurkish() {
     }
 
     private static Locale getTurkeyLocale() {
-        Locale[] availableLocales = Locale.getAvailableLocales();
-        for ( Locale locale : availableLocales ) {
-            if ( locale.getLanguage().equals( "tr" ) ) {
-                return locale;
-            }
+        Locale turkeyLocale = Locale.forLanguageTag( "tr" );
+
+        if ( turkeyLocale == null ) {
+            throw new IllegalStateException( "Can't find Turkey locale." );
         }
-        throw new IllegalStateException( "Can't find Turkey locale." );
-    }
 
+        return turkeyLocale;
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -157,13 +157,12 @@ public void decapitalizeTurkish() {`
`157`	`157`	`}`
`158`	`158`
`159`	`159`	`private static Locale getTurkeyLocale() {`
`160`		`- Locale[] availableLocales = Locale.getAvailableLocales();`
`161`		`- for ( Locale locale : availableLocales ) {`
`162`		`- if ( locale.getLanguage().equals( "tr" ) ) {`
`163`		`- return locale;`
`164`		`- }`
	`160`	`+ Locale turkeyLocale = Locale.forLanguageTag( "tr" );`
	`161`	`+`
	`162`	`+ if ( turkeyLocale == null ) {`
	`163`	`+ throw new IllegalStateException( "Can't find Turkey locale." );`
`165`	`164`	`}`
`166`		`- throw new IllegalStateException( "Can't find Turkey locale." );`
`167`		`- }`
`168`	`165`
	`166`	`+ return turkeyLocale;`
	`167`	`+ }`
`169`	`168`	`}`