Hm indeed. I found a number of issues with my previous "fix" #4105. One was not understanding wordwrap() - can't use the break parameter with anything but \n really without doing gymnastics. Also need to de-tab before using it. Also need to wordwrap the command list separately in order to preserve its columns.

See gitlost#8 for fixes for these, which also dispenses with the arbitrary WP_CLI_HELP_WORDWRAP_WIDTH - which never made sense really - to use the very nice existing function \cli\Shell::columns() to wrap to the actual terminal width.

A small issue with \cli\Shell::columns() is that it's not test friendly - the tput command it uses will throw a error if not run interactively, so gitlost#8 needs also the one-line change gitlost/php-cli-tools#1 to suppress it - I had to temporarily point composer to this in order to get the tests to pass.

Extra, more precise tests have been added, and one test changed to wrap to 40 instead of 30 in order to avoid the unwrappable --ssh=[<user>@]<host>[:<port>][<path>] pushing out the max line length.

Wordwrapping breaks formatting of command list #4127

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions