fix: improve external redirects message (#13680)

florian-lefebvre · sarah11918 · web-flow · commit 18e1b978f045 · 2025-04-27T17:18:03.000+02:00
Co-authored-by: Sarah Rainsberger &lt;5098874+sarah11918@users.noreply.github.com&gt;
diff --git a/.changeset/flat-chicken-shout.md b/.changeset/flat-chicken-shout.md
@@ -0,0 +1,5 @@
+
+'astro': patch
+---
+
+Improves the `UnsupportedExternalRedirect` error message to include more details such as the concerned destination
diff --git a/packages/astro/src/core/errors/errors-data.ts b/packages/astro/src/core/errors/errors-data.ts
@@ -976,7 +976,8 @@ export const RedirectWithNoLocation = {
 export const UnsupportedExternalRedirect = {
 	name: 'UnsupportedExternalRedirect',
 	title: 'Unsupported or malformed URL.',
-	message: 'An external redirect must start with http or https, and must be a valid URL.',
+	message: (from: string, to: string) => `The destination URL in the external redirect from "${from}" to "${to}" is unsupported.`,
+	hint: 'An external redirect must start with http or https, and must be a valid URL.',
 } satisfies ErrorData;
 
 /**
diff --git a/packages/astro/src/core/routing/manifest/create.ts b/packages/astro/src/core/routing/manifest/create.ts
@@ -359,7 +359,10 @@ function createRedirectRoutes(
 
 		// check if the link starts with http or https; if not, throw an error
 		if (URL.canParse(destination) && !/^https?:\/\//.test(destination)) {
-			throw new AstroError(UnsupportedExternalRedirect);
+			throw new AstroError({
+				...UnsupportedExternalRedirect,
+				message: UnsupportedExternalRedirect.message(from, destination),
+			});
 		}
 
 		routes.push({

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
++
 +'astro': patch
 +---
++
 +Improves the `UnsupportedExternalRedirect` error message to include more details such as the concerned destination