JAVA-1769: Allocate exact buffer size for outgoing requests

olim7t · olim7t · commit 85fe9bb1b688 · 2018-03-05T11:22:43.000-08:00
diff --git a/changelog/README.md b/changelog/README.md
@@ -4,6 +4,7 @@
 
 ### 4.0.0-alpha4 (in progress)
 
+- [improvement] JAVA-1769: Allocate exact buffer size for outgoing requests
 - [improvement] JAVA-1772: Revisit multi-response callbacks
 - [new feature] JAVA-1537: Add remaining socket options
 - [bug] JAVA-1756: Propagate custom payload when preparing a statement
diff --git a/core/src/main/java/com/datastax/oss/driver/internal/core/protocol/ByteBufPrimitiveCodec.java b/core/src/main/java/com/datastax/oss/driver/internal/core/protocol/ByteBufPrimitiveCodec.java
@@ -35,7 +35,7 @@ public ByteBufPrimitiveCodec(ByteBufAllocator allocator) {
 
   @Override
   public ByteBuf allocate(int size) {
-    return allocator.ioBuffer();
+    return allocator.ioBuffer(size, size);
   }
 
   @Override
diff --git a/core/src/test/java/com/datastax/oss/driver/internal/core/protocol/ByteBufPrimitiveCodecTest.java b/core/src/test/java/com/datastax/oss/driver/internal/core/protocol/ByteBufPrimitiveCodecTest.java
@@ -240,7 +240,7 @@ public void should_fail_to_read_long_string_if_not_enough_characters() {
     expectedException.expect(IllegalArgumentException.class);
     expectedException.expectMessage(
         "Not enough bytes to read an UTF-8 serialized string of size 4");
-    ByteBuf source = codec.allocate(2);
+    ByteBuf source = codec.allocate(4);
     source.writeInt(4);
 
     codec.readLongString(source);

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ public ByteBufPrimitiveCodec(ByteBufAllocator allocator) {`
`35`	`35`
`36`	`36`	`@Override`
`37`	`37`	`public ByteBuf allocate(int size) {`
`38`		`- return allocator.ioBuffer();`
	`38`	`+ return allocator.ioBuffer(size, size);`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`@Override`