[@rushstack/heft-config-file] Replace node structuredClone (microsoft#5206)

sherlockfeng · D4N14L · web-flow · commit 320957321041 · 2025-04-24T15:21:57.000-07:00
* chore: replace node structuredclone

* Update common/changes/@rushstack/heft-config-file/chore-replace-node-structuredclone_2025-04-24-03-50.json

Co-authored-by: Daniel &lt;3473356+D4N14L@users.noreply.github.com&gt;

* feat: alphabetically sort dependencies and add TODO

---------

Co-authored-by: sherlockfeng &lt;sherlockfeng@users.noreply.github.com&gt;
Co-authored-by: Daniel &lt;3473356+D4N14L@users.noreply.github.com&gt;
diff --git a/common/changes/@rushstack/heft-config-file/chore-replace-node-structuredclone_2025-04-24-03-50.json b/common/changes/@rushstack/heft-config-file/chore-replace-node-structuredclone_2025-04-24-03-50.json
@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@rushstack/heft-config-file",
+      "comment": "Fix Node 16 compatibility by using non-built-in structuredClone",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@rushstack/heft-config-file"
+}
diff --git a/common/config/rush/browser-approved-packages.json b/common/config/rush/browser-approved-packages.json
@@ -46,6 +46,10 @@
       "name": "@rushstack/rush-vscode-command-webview",
       "allowedCategories": [ "vscode-extensions" ]
     },
+    {
+      "name": "@ungap/structured-clone",
+      "allowedCategories": [ "libraries" ]
+    },
     {
       "name": "axios",
       "allowedCategories": [ "libraries" ]
diff --git a/common/config/subspaces/build-tests-subspace/pnpm-lock.yaml b/common/config/subspaces/build-tests-subspace/pnpm-lock.yaml
diff --git a/common/config/subspaces/build-tests-subspace/repo-state.json b/common/config/subspaces/build-tests-subspace/repo-state.json
@@ -1,6 +1,6 @@
 // DO NOT MODIFY THIS FILE MANUALLY BUT DO COMMIT IT. It is generated and used by Rush.
 {
-  "pnpmShrinkwrapHash": "d9e805ea30f80e290b5d5ea83856c8b5d7302941",
+  "pnpmShrinkwrapHash": "e47112c7d099f189f37770e10351e406cf1ec451",
   "preferredVersionsHash": "54149ea3f01558a859c96dee2052b797d4defe68",
-  "packageJsonInjectedDependenciesHash": "949bb6038c34cb0580b82a6f728b26a66fff3177"
+  "packageJsonInjectedDependenciesHash": "a1277b20787fa46cb118a7352d5ca6a922a1098b"
 }
diff --git a/common/config/subspaces/default/pnpm-lock.yaml b/common/config/subspaces/default/pnpm-lock.yaml
diff --git a/common/config/subspaces/default/repo-state.json b/common/config/subspaces/default/repo-state.json
@@ -1,5 +1,5 @@
 // DO NOT MODIFY THIS FILE MANUALLY BUT DO COMMIT IT. It is generated and used by Rush.
 {
-  "pnpmShrinkwrapHash": "1cd4f5444a9d6a085d5418372291de283264d9fb",
+  "pnpmShrinkwrapHash": "cff3c4ef9a27a2377b9fb1f907c5441b3996d5fb",
   "preferredVersionsHash": "54149ea3f01558a859c96dee2052b797d4defe68"
 }
diff --git a/libraries/heft-config-file/package.json b/libraries/heft-config-file/package.json
@@ -24,11 +24,13 @@
     "@rushstack/node-core-library": "workspace:*",
     "@rushstack/rig-package": "workspace:*",
     "@rushstack/terminal": "workspace:*",
+    "@ungap/structured-clone": "~1.3.0",
     "jsonpath-plus": "~10.3.0"
   },
   "devDependencies": {
-    "local-eslint-config": "workspace:*",
     "@rushstack/heft": "0.71.2",
-    "decoupled-local-node-rig": "workspace:*"
+    "@types/ungap__structured-clone": "~1.2.0",
+    "decoupled-local-node-rig": "workspace:*",
+    "local-eslint-config": "workspace:*"
   }
 }
diff --git a/libraries/heft-config-file/src/ConfigurationFileBase.ts b/libraries/heft-config-file/src/ConfigurationFileBase.ts
@@ -4,6 +4,7 @@
 import * as nodeJsPath from 'path';
 import { JSONPath } from 'jsonpath-plus';
 import { JsonSchema, JsonFile, Import, FileSystem } from '@rushstack/node-core-library';
+import structuredClone from '@ungap/structured-clone';
 import type { ITerminal } from '@rushstack/terminal';
 
 interface IConfigurationJson {
@@ -624,7 +625,10 @@ export abstract class ConfigurationFileBase<TConfigurationFile, TExtraOptions ex
     projectFolderPath: string | undefined
   ): IConfigurationJson & TConfigurationFile {
     // Deep copy the configuration file because different callers might contextualize properties differently.
-    const result: IConfigurationJson & TConfigurationFile = structuredClone(entry.configurationFile);
+    // TODO: Replace this version of structuredClone with the built-in version once Node 16 support is dropped on the TikTok side
+    const result: IConfigurationJson & TConfigurationFile = structuredClone<
+      IConfigurationJson & TConfigurationFile
+    >(entry.configurationFile);
 
     const { resolvedConfigurationFilePath } = entry;
 

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`// DO NOT MODIFY THIS FILE MANUALLY BUT DO COMMIT IT. It is generated and used by Rush.`
`2`	`2`	`{`
`3`		`- "pnpmShrinkwrapHash": "d9e805ea30f80e290b5d5ea83856c8b5d7302941",`
	`3`	`+ "pnpmShrinkwrapHash": "e47112c7d099f189f37770e10351e406cf1ec451",`
`4`	`4`	`"preferredVersionsHash": "54149ea3f01558a859c96dee2052b797d4defe68",`
`5`		`- "packageJsonInjectedDependenciesHash": "949bb6038c34cb0580b82a6f728b26a66fff3177"`
	`5`	`+ "packageJsonInjectedDependenciesHash": "a1277b20787fa46cb118a7352d5ca6a922a1098b"`
`6`	`6`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`// DO NOT MODIFY THIS FILE MANUALLY BUT DO COMMIT IT. It is generated and used by Rush.`
`2`	`2`	`{`
`3`		`- "pnpmShrinkwrapHash": "1cd4f5444a9d6a085d5418372291de283264d9fb",`
	`3`	`+ "pnpmShrinkwrapHash": "cff3c4ef9a27a2377b9fb1f907c5441b3996d5fb",`
`4`	`4`	`"preferredVersionsHash": "54149ea3f01558a859c96dee2052b797d4defe68"`
`5`	`5`	`}`