Merge pull request cli#897 from vilmibm/hide-review

Nate Smith · web-flow · commit aac9947a51b8 · 2020-05-11T12:58:45.000-05:00
hide stuff
diff --git a/command/pr_review.go b/command/pr_review.go
@@ -11,7 +11,8 @@ import (
 )
 
 func init() {
-	prCmd.AddCommand(prReviewCmd)
+	// TODO re-register post release
+	// prCmd.AddCommand(prReviewCmd)
 
 	prReviewCmd.Flags().BoolP("approve", "a", false, "Approve pull request")
 	prReviewCmd.Flags().BoolP("request-changes", "r", false, "Request changes on a pull request")
diff --git a/command/pr_review_test.go b/command/pr_review_test.go
@@ -8,6 +8,7 @@ import (
 )
 
 func TestPRReview_validation(t *testing.T) {
+	t.Skip("skipping until release is done")
 	initBlankContext("", "OWNER/REPO", "master")
 	http := initFakeHTTP()
 	for _, cmd := range []string{
@@ -22,6 +23,7 @@ func TestPRReview_validation(t *testing.T) {
 }
 
 func TestPRReview_url_arg(t *testing.T) {
+	t.Skip("skipping until release is done")
 	initBlankContext("", "OWNER/REPO", "master")
 	http := initFakeHTTP()
 	http.StubRepoResponse("OWNER", "REPO")
@@ -67,6 +69,7 @@ func TestPRReview_url_arg(t *testing.T) {
 }
 
 func TestPRReview_number_arg(t *testing.T) {
+	t.Skip("skipping until release is done")
 	initBlankContext("", "OWNER/REPO", "master")
 	http := initFakeHTTP()
 	http.StubRepoResponse("OWNER", "REPO")
@@ -112,6 +115,7 @@ func TestPRReview_number_arg(t *testing.T) {
 }
 
 func TestPRReview_no_arg(t *testing.T) {
+	t.Skip("skipping until release is done")
 	initBlankContext("", "OWNER/REPO", "feature")
 	http := initFakeHTTP()
 	http.StubRepoResponse("OWNER", "REPO")
@@ -147,6 +151,7 @@ func TestPRReview_no_arg(t *testing.T) {
 }
 
 func TestPRReview_blank_comment(t *testing.T) {
+	t.Skip("skipping until release is done")
 	initBlankContext("", "OWNER/REPO", "master")
 	http := initFakeHTTP()
 	http.StubRepoResponse("OWNER", "REPO")
@@ -156,6 +161,7 @@ func TestPRReview_blank_comment(t *testing.T) {
 }
 
 func TestPRReview_blank_request_changes(t *testing.T) {
+	t.Skip("skipping until release is done")
 	initBlankContext("", "OWNER/REPO", "master")
 	http := initFakeHTTP()
 	http.StubRepoResponse("OWNER", "REPO")
@@ -165,6 +171,7 @@ func TestPRReview_blank_request_changes(t *testing.T) {
 }
 
 func TestPRReview(t *testing.T) {
+	t.Skip("skipping until release is done")
 	type c struct {
 		Cmd           string
 		ExpectedEvent string
diff --git a/command/root.go b/command/root.go
@@ -271,7 +271,7 @@ func rootHelpFunc(command *cobra.Command, s []string) {
 		s := "  " + rpad(c.Name()+":", c.NamePadding()) + c.Short
 		if includes(coreCommandNames, c.Name()) {
 			coreCommands = append(coreCommands, s)
-		} else {
+		} else if c != creditsCmd {
 			additionalCommands = append(additionalCommands, s)
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -11,7 +11,8 @@ import (`
`11`	`11`	`)`
`12`	`12`
`13`	`13`	`func init() {`
`14`		`- prCmd.AddCommand(prReviewCmd)`
	`14`	`+ // TODO re-register post release`
	`15`	`+ // prCmd.AddCommand(prReviewCmd)`
`15`	`16`
`16`	`17`	`prReviewCmd.Flags().BoolP("approve", "a", false, "Approve pull request")`
`17`	`18`	`prReviewCmd.Flags().BoolP("request-changes", "r", false, "Request changes on a pull request")`
Original file line number	Diff line number	Diff line change
`@@ -271,7 +271,7 @@ func rootHelpFunc(command *cobra.Command, s []string) {`
`271`	`271`	`s := " " + rpad(c.Name()+":", c.NamePadding()) + c.Short`
`272`	`272`	`if includes(coreCommandNames, c.Name()) {`
`273`	`273`	`coreCommands = append(coreCommands, s)`
`274`		`- } else {`
	`274`	`+ } else if c != creditsCmd {`
`275`	`275`	`additionalCommands = append(additionalCommands, s)`
`276`	`276`	`}`
`277`	`277`	`}`