Add ghinstance tests

mislav · mislav · commit 87632791d639 · 2020-07-27T20:09:57.000+02:00
diff --git a/internal/ghinstance/host.go b/internal/ghinstance/host.go
@@ -7,14 +7,17 @@ import (
 
 const defaultHostname = "github.com"
 
+// Default returns the host name of the default GitHub instance
 func Default() string {
 	return defaultHostname
 }
 
+// IsEnterprise reports whether a non-normalized host name looks like a GHE instance
 func IsEnterprise(h string) bool {
 	return NormalizeHostname(h) != defaultHostname
 }
 
+// NormalizeHostname returns the canonical host name of a GitHub instance
 func NormalizeHostname(h string) string {
 	hostname := strings.ToLower(h)
 	if strings.HasSuffix(hostname, "."+defaultHostname) {
diff --git a/internal/ghinstance/host_test.go b/internal/ghinstance/host_test.go
@@ -0,0 +1,121 @@
+package ghinstance
+
+import (
+	"testing"
+)
+
+func TestIsEnterprise(t *testing.T) {
+	tests := []struct {
+		host string
+		want bool
+	}{
+		{
+			host: "github.com",
+			want: false,
+		},
+		{
+			host: "api.github.com",
+			want: false,
+		},
+		{
+			host: "ghe.io",
+			want: true,
+		},
+		{
+			host: "example.com",
+			want: true,
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.host, func(t *testing.T) {
+			if got := IsEnterprise(tt.host); got != tt.want {
+				t.Errorf("IsEnterprise() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}
+
+func TestNormalizeHostname(t *testing.T) {
+	tests := []struct {
+		host string
+		want string
+	}{
+		{
+			host: "GitHub.com",
+			want: "github.com",
+		},
+		{
+			host: "api.github.com",
+			want: "github.com",
+		},
+		{
+			host: "ssh.github.com",
+			want: "github.com",
+		},
+		{
+			host: "upload.github.com",
+			want: "github.com",
+		},
+		{
+			host: "GHE.IO",
+			want: "ghe.io",
+		},
+		{
+			host: "git.my.org",
+			want: "git.my.org",
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.host, func(t *testing.T) {
+			if got := NormalizeHostname(tt.host); got != tt.want {
+				t.Errorf("NormalizeHostname() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}
+
+func TestGraphQLEndpoint(t *testing.T) {
+	tests := []struct {
+		host string
+		want string
+	}{
+		{
+			host: "github.com",
+			want: "https://api.github.com/graphql",
+		},
+		{
+			host: "ghe.io",
+			want: "https://ghe.io/api/graphql",
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.host, func(t *testing.T) {
+			if got := GraphQLEndpoint(tt.host); got != tt.want {
+				t.Errorf("GraphQLEndpoint() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}
+
+func TestRESTPrefix(t *testing.T) {
+	tests := []struct {
+		host string
+		want string
+	}{
+		{
+			host: "github.com",
+			want: "https://api.github.com/",
+		},
+		{
+			host: "ghe.io",
+			want: "https://ghe.io/api/v3/",
+		},
+	}
+	for _, tt := range tests {
+		t.Run(tt.host, func(t *testing.T) {
+			if got := RESTPrefix(tt.host); got != tt.want {
+				t.Errorf("RESTPrefix() = %v, want %v", got, tt.want)
+			}
+		})
+	}
+}

Original file line number	Diff line number	Diff line change
`@@ -7,14 +7,17 @@ import (`
`7`	`7`
`8`	`8`	`const defaultHostname = "github.com"`
`9`	`9`
	`10`	`+// Default returns the host name of the default GitHub instance`
`10`	`11`	`func Default() string {`
`11`	`12`	`return defaultHostname`
`12`	`13`	`}`
`13`	`14`
	`15`	`+// IsEnterprise reports whether a non-normalized host name looks like a GHE instance`
`14`	`16`	`func IsEnterprise(h string) bool {`
`15`	`17`	`return NormalizeHostname(h) != defaultHostname`
`16`	`18`	`}`
`17`	`19`
	`20`	`+// NormalizeHostname returns the canonical host name of a GitHub instance`
`18`	`21`	`func NormalizeHostname(h string) string {`
`19`	`22`	`hostname := strings.ToLower(h)`
`20`	`23`	`if strings.HasSuffix(hostname, "."+defaultHostname) {`