Only validate --hostname when flag was provided

mislav · mislav · commit 0de3f678bc26 · 2020-09-01T13:19:19.000+02:00
diff --git a/pkg/cmd/auth/login/login.go b/pkg/cmd/auth/login/login.go
@@ -87,8 +87,10 @@ func NewCmdLogin(f *cmdutil.Factory, runF func(*LoginOptions) error) *cobra.Comm
 				}
 			}
 
-			if err := hostnameValidator(opts.Hostname); err != nil {
-				return &cmdutil.FlagError{Err: fmt.Errorf("error parsing --hostname: %w", err)}
+			if cmd.Flags().Changed("hostname") {
+				if err := hostnameValidator(opts.Hostname); err != nil {
+					return &cmdutil.FlagError{Err: fmt.Errorf("error parsing --hostname: %w", err)}
+				}
 			}
 
 			if runF != nil {

Original file line number	Diff line number	Diff line change
`@@ -87,8 +87,10 @@ func NewCmdLogin(f cmdutil.Factory, runF func(LoginOptions) error) *cobra.Comm`
`87`	`87`	`}`
`88`	`88`	`}`
`89`	`89`
`90`		`- if err := hostnameValidator(opts.Hostname); err != nil {`
`91`		`- return &cmdutil.FlagError{Err: fmt.Errorf("error parsing --hostname: %w", err)}`
	`90`	`+ if cmd.Flags().Changed("hostname") {`
	`91`	`+ if err := hostnameValidator(opts.Hostname); err != nil {`
	`92`	`+ return &cmdutil.FlagError{Err: fmt.Errorf("error parsing --hostname: %w", err)}`
	`93`	`+ }`
`92`	`94`	`}`
`93`	`95`
`94`	`96`	`if runF != nil {`