A few tweaks for hosted buttons per issue #2

Jeff Harrell · Jeff Harrell · commit 4474d9b3e557 · 2012-10-19T17:36:29.000-07:00
diff --git a/README.md b/README.md
@@ -11,7 +11,7 @@ Buy Now buttons are for single item purchases.
 
 ```html
 <script src="paypal.js?merchant=MERCHANT_ID"
-    data-type="buynow"
+    data-button="buynow"
     data-item_name="Buy me now!"
     data-amount="1.00"
 ></script>
@@ -23,7 +23,7 @@ Add To Cart buttons lets users add multiple items to their PayPal cart.
 
 ```html
 <script src="paypal.js?merchant=MERCHANT_ID"
-    data-type="cart"
+    data-button="cart"
     data-item_name="Add to cart!"
     data-amount="1.00"
 ></script>
@@ -33,25 +33,25 @@ Add To Cart buttons lets users add multiple items to their PayPal cart.
 You can pass additional data values to the button as well. The following are currently supported:
 
 **Item details**
-* `data-item_name` Description of the item
-* `data-item_number` The number of the item
+* `data-item-name` Description of the item
+* `data-item-number` The number of the item
 * `data-quantity` Number of items
 * `data-shipping` The cost of shipping this item
 * `data-shipping2` The cost of shipping each additional unit of this item
 * `data-tax` Transaction-based tax override variable
 
 **Discounts**
-* `data-discount_amount` Discount amount associated with an item
-* `data-discount_amount2` Discount amount associated with each additional quantity of the item
-* `data-discount_rate` Discount rate (percentage) for an item
-* `data-discount_rate2` Discount rate (percentage) for each additional quantity of the item
-* `data-discount_num` Number of additional quantities of the item to which the discount applies
+* `data-discount-amount` Discount amount associated with an item
+* `data-discount-amount2` Discount amount associated with each additional quantity of the item
+* `data-discount-rate` Discount rate (percentage) for an item
+* `data-discount-rate2` Discount rate (percentage) for each additional quantity of the item
+* `data-discount-num` Number of additional quantities of the item to which the discount applies
 
 
 ## Merchant ID
 Your merchant ID needs to be added to the URL of the referenced script. This ID can either be your Secure Merchant ID, which can be found by logging into your PayPal account and visiting your profile, or your email address.
 
-## Authors
 
+## Authors
 **Jeff Harrell**  
-[https://github.com/jeffharrell](https://github.com/jeffharrell)
+[https://github.com/jeffharrell](https://github.com/jeffharrell)
diff --git a/index.html b/index.html
@@ -129,8 +129,8 @@ <h3 id="buy-now">Buy Now</h3>
 <p>Buy Now buttons are for single item purchases.</p>
 
 <pre><code>&lt;script src="paypal.js?merchant=6XF3MPZBZV6HU"
-    data-type="buynow"
-    data-item_name="Buy me now!"
+    data-button="buynow"
+    data-item-name="Buy me now!"
     data-amount="1.00"
 &gt;&lt;/script&gt;</code></pre>
 
@@ -139,16 +139,31 @@ <h3 id="buy-now">Buy Now</h3>
     data-item_name="Buy me now!"
     data-amount="1.00"
 ></script>
-</p>
+
+
+<h3 id="hosted-buttons">Hosted Buttons</h3>
+
+<p>Hosted buttons are extra secure.</p>
+
+<pre><code>&lt;script src="paypal.js?merchant=6XF3MPZBZV6HU"
+	data-button="cart"
+    data-hosted_button_id="8R63A645E2QB6"
+&gt;&lt;/script&gt;</code></pre>
+
+<script src="paypal.js?merchant=6XF3MPZBZV6HU"
+	data-button="cart"
+    data-hosted_button_id="8R63A645E2QB6"
+></script>
+
 
 <h3 id="add-to-cart">Add To Cart</h3>
 
 <p>Add To Cart buttons lets users add multiple items to their PayPal cart.</p>
 
 
 <pre><code>&lt;script src="paypal.js?merchant=6XF3MPZBZV6HU"
-    data-type="cart"
-    data-item_name="Add to cart!"
+    data-button="cart"
+    data-item-name="Add to cart!"
     data-amount="1.00"
 &gt;&lt;/script&gt;</code></pre>
 
diff --git a/paypal.js b/paypal.js
@@ -11,9 +11,10 @@ PAYPAL.apps = PAYPAL.apps || {};
 
 
 	// Don't execute the code multiple times!
-	if (PAYPAL.apps.DynamicButton) {
-		return;
-	}
+	// See issue #5
+	//if (PAYPAL.apps.DynamicButton) {
+	//	return;
+	//}
 
 
 	var PAYPAL_URL = 'https://www.paypal.com/cgi-bin/webscr',
