Skip to content

Node 12.5 Deprecation Warning (worker.terminate()) #43

@Haidy777

Description

@Haidy777

Hello,

I've just started using this great library. Since 12.5. worker.terminate() throws a deprecation Warning, as it returns a Promise now (see nodejs/node#28021).

Correct me if I am wrong, but

this.workers[i].worker.terminate(() => {
should be the only position where this should be changed?

I'll try to submit a PR to change it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions