chore: Add separate go_feature_serving flag (feast-dev#2968)

felixwang9817 · web-flow · commit aa2a86acf4b9 · 2022-07-21T22:32:07.000-07:00
Add separate `go_feature_serving` flag to distinguish between Go feature serving and embedded Go code

Signed-off-by: Felix Wang &lt;wangfelix98@gmail.com&gt;
diff --git a/.github/workflows/build_wheels.yml b/.github/workflows/build_wheels.yml
@@ -245,5 +245,5 @@ jobs:
           feast apply
           echo "$TEST_SCRIPT" > run-and-wait.sh
           pip install cffi
-          printf "\ngo_feature_retrieval: True" >> feature_store.yaml
+          printf "\ngo_feature_serving: True" >> feature_store.yaml
           bash run-and-wait.sh feast serve
diff --git a/sdk/python/feast/cli.py b/sdk/python/feast/cli.py
@@ -668,7 +668,7 @@ def serve_command(
 
     if go:
         # Turn on Go feature retrieval.
-        store.config.go_feature_retrieval = True
+        store.config.go_feature_serving = True
 
     store.serve(host, port, type_, no_access_log, no_feature_log)
 
diff --git a/sdk/python/feast/feature_store.py b/sdk/python/feast/feature_store.py
@@ -1564,7 +1564,7 @@ def _get_online_features(
             for k, v in entity_values.items()
         }
 
-        # If Go feature server is enabled, send request to it instead of going through regular Python logic
+        # If the embedded Go code is enabled, send request to it instead of going through regular Python logic.
         if self.config.go_feature_retrieval:
             self._lazy_init_go_server()
 
@@ -2217,7 +2217,7 @@ def serve(
     ) -> None:
         """Start the feature consumption server locally on a given port."""
         type_ = type_.lower()
-        if self.config.go_feature_retrieval:
+        if self.config.go_feature_serving:
             # Start go server instead of python if the flag is enabled
             self._lazy_init_go_server()
             enable_logging = (
diff --git a/sdk/python/feast/repo_config.py b/sdk/python/feast/repo_config.py
@@ -139,7 +139,11 @@ class RepoConfig(FeastBaseModel):
 
     repo_path: Optional[Path] = None
 
+    go_feature_serving: Optional[bool] = False
+    """ If True, use the Go feature server instead of the Python feature server. """
+
     go_feature_retrieval: Optional[bool] = False
+    """ If True, use the embedded Go code to retrieve features instead of the Python SDK. """
 
     entity_key_serialization_version: StrictInt = 1
     """ Entity key serialization version: This version is used to control what serialization scheme is
diff --git a/sdk/python/tests/conftest.py b/sdk/python/tests/conftest.py
@@ -268,7 +268,7 @@ def pytest_generate_tests(metafunc: pytest.Metafunc):
             )
 
         if "goserver" in markers:
-            extra_dimensions.append({"go_feature_retrieval": True})
+            extra_dimensions.append({"go_feature_serving": True})
 
         configs = []
         if offline_stores:
@@ -283,7 +283,7 @@ def pytest_generate_tests(metafunc: pytest.Metafunc):
                             **dim,
                         }
                         # temporary Go works only with redis
-                        if config.get("go_feature_retrieval") and (
+                        if config.get("go_feature_serving") and (
                             not isinstance(online_store, dict)
                             or online_store["type"] != "redis"
                         ):
diff --git a/sdk/python/tests/integration/e2e/test_go_feature_server.py b/sdk/python/tests/integration/e2e/test_go_feature_server.py
@@ -59,7 +59,7 @@ def initialized_registry(environment, universal_data_sources):
 
 
 def server_port(environment, server_type: str):
-    if not environment.test_repo_config.go_feature_retrieval:
+    if not environment.test_repo_config.go_feature_serving:
         pytest.skip("Only for Go path")
 
     fs = environment.feature_store
diff --git a/sdk/python/tests/integration/feature_repos/integration_test_repo_config.py b/sdk/python/tests/integration/feature_repos/integration_test_repo_config.py
@@ -37,7 +37,7 @@ class IntegrationTestRepoConfig:
     full_feature_names: bool = True
     infer_features: bool = False
     python_feature_server: bool = False
-    go_feature_retrieval: bool = False
+    go_feature_serving: bool = False
 
     def __repr__(self) -> str:
         if not self.online_store_creator:
@@ -61,7 +61,7 @@ def __repr__(self) -> str:
                 f"{self.offline_store_creator.__name__.split('.')[-1].replace('DataSourceCreator', '')}",
                 online_store_type,
                 f"python_fs:{self.python_feature_server}",
-                f"go_fs:{self.go_feature_retrieval}",
+                f"go_fs:{self.go_feature_serving}",
             ]
         )
 
@@ -77,6 +77,6 @@ def __eq__(self, other):
             and self.online_store == other.online_store
             and self.offline_store_creator == other.offline_store_creator
             and self.online_store_creator == other.online_store_creator
-            and self.go_feature_retrieval == other.go_feature_retrieval
+            and self.go_feature_serving == other.go_feature_serving
             and self.python_feature_server == other.python_feature_server
         )
diff --git a/sdk/python/tests/integration/feature_repos/repo_configuration.py b/sdk/python/tests/integration/feature_repos/repo_configuration.py
@@ -420,7 +420,7 @@ def construct_test_environment(
         batch_engine=test_repo_config.batch_engine,
         repo_path=repo_dir_name,
         feature_server=feature_server,
-        go_feature_retrieval=test_repo_config.go_feature_retrieval,
+        go_feature_serving=test_repo_config.go_feature_serving,
     )
 
     # Create feature_store.yaml out of the config

Original file line number	Diff line number	Diff line change
`@@ -420,7 +420,7 @@ def construct_test_environment(`
`420`	`420`	`batch_engine=test_repo_config.batch_engine,`
`421`	`421`	`repo_path=repo_dir_name,`
`422`	`422`	`feature_server=feature_server,`
`423`		`- go_feature_retrieval=test_repo_config.go_feature_retrieval,`
	`423`	`+ go_feature_serving=test_repo_config.go_feature_serving,`
`424`	`424`	`)`
`425`	`425`
`426`	`426`	`# Create feature_store.yaml out of the config`