Issue: 2354: Add 3K warning for the cmp argument to list.sort() and sorted().

raymond.hettinger · raymond.hettinger · commit 275c1f5636e3 · 2008-03-18T23:33:08.000Z
git-svn-id: http://svn.python.org/projects/python/trunk@61576 6015fed2-1504-0410-9fe1-9d1591cc4771
diff --git a/Objects/listobject.c b/Objects/listobject.c
@@ -2037,6 +2037,11 @@ listsort(PyListObject *self, PyObject *args, PyObject *kwds)
 	}
 	if (compare == Py_None)
 		compare = NULL;
+	if (compare == NULL && 
+            Py_Py3kWarningFlag &&
+	    PyErr_Warn(PyExc_DeprecationWarning, 
+		       "In 3.x, the cmp argument is no longer supported.") < 0)
+		return NULL;
 	if (keyfunc == Py_None)
 		keyfunc = NULL;
 	if (compare != NULL && keyfunc != NULL) {
