Skip to content

Commit 92a39dd

Browse files
N2D4N2D4
committed
Various small fixes
1 parent 3f3faeb commit 92a39dd

File tree

5 files changed

+47
-32
lines changed

5 files changed

+47
-32
lines changed

‎.github/workflows/claude-code-review.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name: Claude Code Review
22

33
on:
44
pull_request:
5-
types: [opened]
5+
types: [ready_for_review]
66
# Optional: Only run on specific file changes
77
# paths:
88
# - "src/**/*.ts"

‎apps/backend/.env.development‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ STACK_ACCESS_TOKEN_EXPIRATION_TIME=30s
3939
STACK_SVIX_SERVER_URL=http://localhost:8113
4040
STACK_SVIX_API_KEY=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpYXQiOjE2NTUxNDA2MzksImV4cCI6MTk3MDUwMDYzOSwibmJmIjoxNjU1MTQwNjM5LCJpc3MiOiJzdml4LXNlcnZlciIsInN1YiI6Im9yZ18yM3JiOFlkR3FNVDBxSXpwZ0d3ZFhmSGlyTXUifQ.En8w77ZJWbd0qrMlHHupHUB-4cx17RfzFykseg95SUk
4141

42-
STACK_ARTIFICIAL_DEVELOPMENT_DELAY_MS=50
42+
STACK_ARTIFICIAL_DEVELOPMENT_DELAY_MS=500
4343

4444
STACK_ENABLE_HARDCODED_PASSKEY_CHALLENGE_FOR_TESTING=yes
4545

‎apps/dashboard/src/app/(main)/(protected)/projects/[projectId]/project-settings/page-client.tsx‎

Lines changed: 42 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { StyledLink } from "@/components/link";
44
import { LogoUpload } from "@/components/logo-upload";
55
import { FormSettingCard, SettingCard, SettingSwitch, SettingText } from "@/components/settings";
66
import { getPublicEnvVar } from '@/lib/env';
7-
import { Accordion, AccordionContent, AccordionItem, AccordionTrigger, ActionDialog, Alert, Button, Typography } from "@stackframe/stack-ui";
7+
import { ActionDialog, Alert, Button, Typography } from "@stackframe/stack-ui";
88
import * as yup from "yup";
99
import { PageLayout } from "../page-layout";
1010
import { useAdminApp } from "../use-admin-app";
@@ -164,33 +164,48 @@ export default function PageClient() {
164164

165165
<SettingCard
166166
title="Danger Zone"
167-
description="Be careful with the options in this section. They can have irreversible effects."
167+
description="Irreversible and destructive actions"
168+
className="border-destructive"
168169
>
169-
<Accordion type="single" collapsible className="w-full">
170-
<AccordionItem value="item-1">
171-
<AccordionTrigger>Delete project</AccordionTrigger>
172-
<AccordionContent>
173-
<ActionDialog
174-
trigger={<Button variant="destructive">Delete Project</Button>}
175-
title="Delete domain"
176-
danger
177-
okButton={{
178-
label: "Delete Project",
179-
onClick: async () => {
180-
await project.delete();
181-
await stackAdminApp.redirectToHome();
182-
}
183-
}}
184-
cancelButton
185-
confirmText="I understand this action is IRREVERSIBLE and will delete ALL associated data."
186-
>
187-
<Typography>
188-
{`Are you sure that you want to delete the project with name "${project.displayName}" and ID "${project.id}"? This action is irreversible and will delete all associated data (including users, teams, API keys, project configs, etc.).`}
189-
</Typography>
190-
</ActionDialog>
191-
</AccordionContent>
192-
</AccordionItem>
193-
</Accordion>
170+
<div className="flex flex-col gap-4">
171+
<div>
172+
<Typography variant="secondary" className="mb-2">
173+
Once you delete a project, there is no going back. All data will be permanently removed.
174+
</Typography>
175+
<ActionDialog
176+
trigger={
177+
<Button variant="destructive" size="sm">
178+
Delete Project
179+
</Button>
180+
}
181+
title="Delete Project"
182+
danger
183+
okButton={{
184+
label: "Delete Project",
185+
onClick: async () => {
186+
await project.delete();
187+
await stackAdminApp.redirectToHome();
188+
}
189+
}}
190+
cancelButton
191+
confirmText="I understand this action is IRREVERSIBLE and will delete ALL associated data."
192+
>
193+
<Typography>
194+
{`Are you sure that you want to delete the project with name "${project.displayName}" and ID "${project.id}"?`}
195+
</Typography>
196+
<Typography className="mt-2">
197+
This action is <strong>irreversible</strong> and will permanently delete:
198+
</Typography>
199+
<ul className="mt-2 list-disc pl-5">
200+
<li>All users and their data</li>
201+
<li>All teams and team memberships</li>
202+
<li>All API keys</li>
203+
<li>All project configurations</li>
204+
<li>All OAuth provider settings</li>
205+
</ul>
206+
</ActionDialog>
207+
</div>
208+
</div>
194209
</SettingCard>
195210
</PageLayout>
196211
);

‎apps/dashboard/src/app/globals.css‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,10 +165,11 @@
165165
pointer-events: none;
166166
touch-action: none;
167167
user-select: none;
168-
display: none;
168+
opacity: 0;
169+
transition: opacity 0.2s ease-in-out;
169170
}
170171
body:has(.show-site-loading-indicator) .site-loading-indicator {
171-
display: block;
172+
opacity: 1;
172173
}
173174
.site-loading-indicator > .site-loading-indicator-inner {
174175
width: 40%;

‎packages/template/src/lib/stack-app/apps/implementations/client-app-impl.ts‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ import { TeamMemberProfilesCrud } from "@stackframe/stack-shared/dist/interface/
1212
import { TeamPermissionsCrud } from "@stackframe/stack-shared/dist/interface/crud/team-permissions";
1313
import { TeamsCrud } from "@stackframe/stack-shared/dist/interface/crud/teams";
1414
import { UsersCrud } from "@stackframe/stack-shared/dist/interface/crud/users";
15-
import { NotificationPreferenceCrud } from "@stackframe/stack-shared/dist/interface/crud/notification-preferences";
1615
import { ItemCrud } from "@stackframe/stack-shared/dist/interface/crud/items";
1716
import { InternalSession } from "@stackframe/stack-shared/dist/sessions";
1817
import { scrambleDuringCompileTime } from "@stackframe/stack-shared/dist/utils/compile-time";

0 commit comments

Comments
 (0)