01 - JavaScript Drum Kit: do not use compiled JS version\

alexrah · alexrah · commit 1cb06060f1fc · 2022-01-23T23:22:41.000+01:00
useful in 2017, not anymore in 2021\
replace keyup event with keydown to get faster response
diff --git a/01 - JavaScript Drum Kit/all.js b/01 - JavaScript Drum Kit/all.js
@@ -8,6 +8,7 @@ const play = (e) =>
         let el;
         if (e.type === 'click'){
             // console.log(e.target.parentNode);
+            //TODO: check if target is already key, then no need to assign parentNode
             let key = e.target.parentNode;
             let audio = key.querySelector('audio');
             key.classList.add('playing');
@@ -22,7 +23,7 @@ const play = (e) =>
             }
         }
 };
-window.addEventListener('keyup', (e)=> {
+window.addEventListener('keydown', (e)=> {
     play(e);
 });
 
diff --git a/01 - JavaScript Drum Kit/index.html b/01 - JavaScript Drum Kit/index.html
@@ -58,7 +58,7 @@
   </div>
 
 
-<script type="text/javascript" src="dist/all.js"></script>
+<script type="text/javascript" src="all.js"></script>
 
 
 </body>
