fix: do not swallow errors from server (#2512)

EslamHiko · web-flow · commit 06583f268b70 · 2020-04-10T15:54:26.000+03:00
diff --git a/lib/Server.js b/lib/Server.js
@@ -687,6 +687,10 @@ class Server {
     } else {
       this.listeningApp = http.createServer(this.app);
     }
+
+    this.listeningApp.on('error', (err) => {
+      this.log.error(err);
+    });
   }
 
   createSocketServer() {
diff --git a/test/server/Server.test.js b/test/server/Server.test.js
@@ -76,6 +76,16 @@ describe('Server', () => {
     });
   });
 
+  it('test listeningApp error reporting', () => {
+    const logMock = jest.fn();
+    const compiler = webpack(config);
+    const server = new Server(compiler, baseDevConfig);
+
+    server.log.error = logMock;
+
+    server.listeningApp.emit('error', new Error('Error !!!'));
+    expect(server.log.error).toBeCalledWith(new Error('Error !!!'));
+  });
   // issue: https://github.com/webpack/webpack-dev-server/issues/1724
   describe('express.static.mine.types', () => {
     it("should success even if mine.types doesn't exist", (done) => {

Original file line number	Diff line number	Diff line change
`@@ -687,6 +687,10 @@ class Server {`
`687`	`687`	`} else {`
`688`	`688`	`this.listeningApp = http.createServer(this.app);`
`689`	`689`	`}`
	`690`	`+`
	`691`	`+ this.listeningApp.on('error', (err) => {`
	`692`	`+ this.log.error(err);`
	`693`	`+ });`
`690`	`694`	`}`
`691`	`695`
`692`	`696`	`createSocketServer() {`