Migration of tests to Jest by niieani · Pull Request #6565 · webpack/webpack

niieani · 2018-02-25T00:48:56Z

@ooflorent Alright, I've done it.

This is with jest:

Test Suites: 1 failed, 65 passed, 66 total
Tests:       1 failed, 126 skipped, 10692 passed, 10819 total
Snapshots:   2 passed, 2 total
Time:        141.898s, estimated 158s
Ran all test suites.

This was before on the same computer with mocha:

  10713 passing (13m)
  127 pending

That's an improvement of almost 6x in terms of speed.

(fewer total number of tests under Mocha, cause I run that test around 4.0-alpha, before merging current master)


```
 FAIL  test/TestCasesDevelopment.test.js (13.204s)
  ● TestCases › development › chunks › runtime › exported tests › should not load a chunk which is included in a already loaded one

    expect(received).toBe(expected) // Object.is equality

    Expected: true
    Received: false

      175 |             __webpack_require__.e(/*! require.ensure */3).then((function(require) {
      176 |                     try {
    > 177 |                             expect(sync).toBe(true);
      178 |                             done();
      179 |                     } catch(e) {
      180 |                             done(e);

      at test/js/development/chunks/runtime/bundle.js:177:18
```

~~~We still need facebook/jest#5673 to ship before we can merge, but this is ready for review.~~~

used regexps: ([a-zA-Z0-9\."'/ +{}\[\]=\-,:?_!]+)\.should\.be\.eql ➡️ expect($1).toBe expect$([\($a-zA-Z0-9\."'/ +{}\[\]=\-,:?_!]+)\)\.toBe$\[ ➡️ expect($1).toEqual([ expect\(([\($a-zA-Z0-9\."'/ +{}\[\]=\-,:?_!]+)\)\.toBe\(\{ ➡️ expect($1).toEqual({

\.to\.have\.property$(.+)$\.toEqual$(.+)$; ➡️ .toHaveProperty($1, $2);

Convert tests to Jest

# Conflicts: # test/BenchmarkTestCases.benchmark.js # test/CachePlugin.unittest.js # test/HotTestCases.test.js # test/NormalModule.unittest.js # test/ProfilingPlugin.unittest.js # test/TestCases.test.js # test/configCases/parsing/harmony-this/index.js # test/configCases/plugins/profiling-plugin/index.js # test/configCases/plugins/profiling-plugin/webpack.config.js # test/watchCases/runtime/static-import/0/index.js # yarn.lock

elsewise haste map generation takes forever with many files in folder

sokra · 2018-04-30T15:35:15Z

Looks good, I noticed one small issue. When running jest in watch mode and running the WatchDetection test, sane emits EPERM errors on windows. sane doesn't seem to check the ignore list when directories are added (https://github.com/amasad/sane/blob/master/src/node_watcher.js#L310) and reading the stats from a removed file seem to cause an EPERM error here (https://github.com/amasad/sane/blob/master/src/node_watcher.js#L306). I believe it's an sane issue. Although it would also be great if watcher errors would be catched (via watcher.on("error")) in jest-haste-map. Anyway, it's not super critical.

# Conflicts: # test/WatchTestCases.test.js

webpack-bot · 2018-04-30T15:46:06Z

@sokra Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@shellscape Please review the new changes.

sokra · 2018-04-30T17:37:12Z

Awesome thanks

devenbansod · 2018-05-01T03:36:07Z

Awesome stuff @niieani !

Thanks @skovhus for https://github.com/skovhus/jest-codemods 🙌

Just throwing it out there:
I had faced some similar issues while transforming test assertions for babel's tests, which had a mix of mocha, chai, assert in babel/babel#7476. I feel I should have noted these down, and regret not reporting them to https://github.com/skovhus/jest-codemods then.

But then I wrote a (seriously) toned down version focusing on assertions that babel's tests required at: https://github.com/devenbansod/jest-expect-codemod

sokra · 2018-05-01T13:41:49Z

I got this random error in watch mode after changing a file. Can't reproduce...

D:\Repos\webpack\node_modules\jest-runtime\build\index.js:581
    const wrapper = this._environment.runScript(transformedFile.script)[
                                                                       ^

TypeError: Cannot read property 'Object.<anonymous>' of null
    at Runtime._execModule (D:\Repos\webpack\node_modules\jest-runtime\build\index.js:581:72)
    at Runtime.requireModule (D:\Repos\webpack\node_modules\jest-runtime\build\index.js:365:14)
    at Runtime.requireModuleOrMock (D:\Repos\webpack\node_modules\jest-runtime\build\index.js:449:19)
    at readdir (D:\Repos\webpack\node_modules\readdirp\readdirp.js:55:25)
    at FSWatcher.<anonymous> (D:\Repos\webpack\node_modules\chokidar\lib\nodefs-handler.js:356:5)
    at FSWatcher.Object.<anonymous>.NodeFsHandler._handleDir (D:\Repos\webpack\node_modules\chokidar\lib\nodefs-handler.js:407:18)
    at FSWatcher.<anonymous> (D:\Repos\webpack\node_modules\chokidar\lib\nodefs-handler.js:456:19)
    at FSWatcher.<anonymous> (D:\Repos\webpack\node_modules\chokidar\lib\nodefs-handler.js:461:16)
    at D:\Repos\webpack\node_modules\graceful-fs\polyfills.js:287:18
    at FSReqWrap.oncomplete (fs.js:153:5)

sokra · 2018-05-01T13:44:16Z

@niieani What's the reason for using Math.random().toPrecision(21).slice(2) in the folder name for watch-src tests?

sokra · 2018-05-01T13:58:51Z

I also ran into this issue jestjs/jest#4820 but no blocker

sokra · 2018-05-01T14:15:08Z

The slashes are also a bit weird here, but not important (windows)

sokra · 2018-05-01T15:09:07Z

When running jest in watch mode and running the WatchDetection test, sane emits EPERM errors on windows. sane doesn't seem to check the ignore list when directories are added (https://github.com/amasad/sane/blob/master/src/node_watcher.js#L310) and reading the stats from a removed file seem to cause an EPERM error here (https://github.com/amasad/sane/blob/master/src/node_watcher.js#L306). I believe it's an sane issue. Although it would also be great if watcher errors would be catched (via watcher.on("error")) in jest-haste-map. Anyway, it's not super critical.

It's worse than I original estimated. The whole jest watch process crashes.

Please handle the error event in jest-haste-map.

niieani · 2018-05-01T17:32:16Z

@sokra Math.random().toPrecision(21).slice(2) is needed to always create a new folder. Jest creates their haste map, I think based on package.json files. When there are duplicates of the same path and the same package name, it can cause issues.

Not sure what to do with the Windows issues, I'm on macOS. :/

ooflorent and others added 26 commits January 24, 2018 17:29

Migrate unit tests to Jest

2f4910b

Migrate integration tests to Jest

cd419d0

Migrate HotTestCases to Jest

998f768

wip

7a70020

jest migration: use forced tests

009772c

migrate should to expect, part 2 (manual)

a6c2aca

migrate should to expect, part 3

9dc12ff

\.to\.have\.property$(.+)$\.toEqual$(.+)$; ➡️ .toHaveProperty($1, $2);

ConfigTextCases: add expect to globalContext

37e002c

migrate should to expect, part 4 (manual)

075fcc3

migrate WatchTestCases

c01735e

migrate TestCases

5f4b4be

fix ExternalModule.unittest

5a5a95a

add testConfig.timeout to ConfigTestCases

f0ef3fd

migrate BenchmarkTestCases

b823449

add default testMatcher to package.json

e425dea

feedback while compiling TestCases

5ed75dd

few more test migration fixes

3d23bbc

Merge pull request webpack#6396 from niieani/jest

b7ce843

Convert tests to Jest

Fix wrong regexp replacements

aa217e9

update jest to 22.4.2

14d6497

split TestCases into mulitple files for better batching in jest

47a16eb

migrate away from forced tests to a beforeAll hook

b2c54f1

fix a few more expects and make the test output paths more sturdy

e7a671f

fix expect's of one more test

7282e95

integrate jest with CI

e04b476

webpack-bot added PR: unreviewed PR: non-main labels Feb 25, 2018

sokra requested a review from ooflorent February 25, 2018 01:25

montogeek approved these changes Apr 29, 2018

View reviewed changes

sokra added 5 commits April 30, 2018 15:29

update yarn.lock

70d647b

add modulePathIgnorePatterns

cc0148b

elsewise haste map generation takes forever with many files in folder

ignore paths from WatchDetection test case

ff41487

Merge branch 'master' into jest

4229a95

remove spammy output in CI

908b465

webpack-bot added PR: review-outdated and removed PR: reviewed-approved labels Apr 30, 2018

shellscape approved these changes Apr 30, 2018

View reviewed changes

Merge branch 'master' into jest

9958930

# Conflicts: # test/WatchTestCases.test.js

webpack-bot added PR: reviewed-approved PR: review-outdated and removed PR: review-outdated PR: reviewed-approved labels Apr 30, 2018

ooflorent approved these changes Apr 30, 2018

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: review-outdated labels Apr 30, 2018

sokra approved these changes Apr 30, 2018

View reviewed changes

sokra merged commit fe0eb45 into webpack:master Apr 30, 2018

ZuBB mentioned this pull request Nov 21, 2018

Switch from QUnit to Jasmine twbs/bootstrap#27542

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Migration of tests to Jest#6565

Migration of tests to Jest#6565
sokra merged 102 commits intowebpack:masterfrom
niieani:jest

niieani commented Feb 25, 2018 •

edited

Loading

Uh oh!

sokra commented Apr 30, 2018

Uh oh!

webpack-bot commented Apr 30, 2018

Uh oh!

sokra commented Apr 30, 2018

Uh oh!

devenbansod commented May 1, 2018

Uh oh!

sokra commented May 1, 2018

Uh oh!

sokra commented May 1, 2018

Uh oh!

sokra commented May 1, 2018

Uh oh!

sokra commented May 1, 2018

Uh oh!

sokra commented May 1, 2018 •

edited

Loading

Uh oh!

niieani commented May 1, 2018 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

niieani commented Feb 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sokra commented Apr 30, 2018

Uh oh!

webpack-bot commented Apr 30, 2018

Uh oh!

sokra commented Apr 30, 2018

Uh oh!

devenbansod commented May 1, 2018

Uh oh!

sokra commented May 1, 2018

Uh oh!

sokra commented May 1, 2018

Uh oh!

sokra commented May 1, 2018

Uh oh!

sokra commented May 1, 2018

Uh oh!

sokra commented May 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

niieani commented May 1, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

niieani commented Feb 25, 2018 •

edited

Loading

sokra commented May 1, 2018 •

edited

Loading

niieani commented May 1, 2018 •

edited

Loading