Skip to content

Incorrect absolute source map paths on Windows #1770

@antigremlin

Description

@antigremlin

The logic producing relative request paths in source maps is broken on Windows because it converts backslashes to forward slashes not in all cases. This leads to absolute paths in source maps which prevents debugging from IntelliJ WebStorm (as an example of a problem).

EDIT: There are no real failures. The problem is caused by babel-loader See comments below.
(This manifests as test failures in the ConfigTestCases suite. Example of a failure:)

AssertionError: expected Array [
  'dummy:///webpack/bootstrap c6577ccbfbeb94c1e520',
  'dummy:///D:/src/webpack/webpack/test/configCases/filename-template/module-filename-template/test.js',
  'dummy:///D:/src/webpack/webpack/test/configCases/filename-template/module-filename-template/index.js'
] to contain 'dummy:///./test.js'
    at Assertion.fail (D:\src\webpack\webpack\test\js\config\extract-text\issue-14\bundle0.js:1018:18)
    at Assertion.prop.value (D:\src\webpack\webpack\test\js\config\extract-text\issue-14\bundle0.js:903:18)
    at Context.<anonymous> (D:\src\webpack\webpack\test\js\config\filename-template\module-filename-template\bundle0.js:65:22)

List of failing test cases:

  • ConfigTestCases:filename-template-module-filename-template
  • ConfigTestCases:source-map:exclude-chunks-source-map
  • ConfigTestCases:source-map:line-to-line
  • ConfigTestCases:source-map:sources-array-production
  • ConfigTestCases:source-map:sources-array-production-cheap-map

Cause of the problem is code in RequestShortener.js. Pull request will follow.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions