Merge pull request #16144 from KurumiRin/main

sokra · web-flow · commit c109651dd302 · 2022-11-09T10:44:30.000+01:00
fix: when the jobs parameter is an empty array, block unnecessary runCodeGenerationJobs
diff --git a/lib/Compilation.js b/lib/Compilation.js
@@ -3192,6 +3192,9 @@ Or do you want to use the entrypoints '${name}' and '${runtime}' independently o
 	}
 
 	_runCodeGenerationJobs(jobs, callback) {
+		if (jobs.length === 0) {
+			return callback();
+		}
 		let statModulesFromCache = 0;
 		let statModulesGenerated = 0;
 		const { chunkGraph, moduleGraph, dependencyTemplates, runtimeTemplate } =
diff --git a/test/__snapshots__/StatsTestCases.basictest.js.snap b/test/__snapshots__/StatsTestCases.basictest.js.snap
@@ -1365,7 +1365,6 @@ asset <CLR=32,BOLD>main.js</CLR> 84 bytes <CLR=32,BOLD>[emitted]</CLR> (name: ma
 <CLR=BOLD>LOG from webpack.Compilation</CLR>
     <CLR=BOLD>1 modules hashed, 0 from cache (1 variants per module in average)</CLR>
     <CLR=BOLD>100% code generated (1 generated, 0 from cache)</CLR>
-    <CLR=BOLD>NaN% code generated (0 generated, 0 from cache)</CLR>
 + 24 hidden lines
 
 <CLR=BOLD>LOG from webpack.FlagDependencyExportsPlugin</CLR>

Original file line number	Diff line number	Diff line change
`@@ -3192,6 +3192,9 @@ Or do you want to use the entrypoints '${name}' and '${runtime}' independently o`
`3192`	`3192`	`}`
`3193`	`3193`
`3194`	`3194`	`_runCodeGenerationJobs(jobs, callback) {`
	`3195`	`+ if (jobs.length === 0) {`
	`3196`	`+ return callback();`
	`3197`	`+ }`
`3195`	`3198`	`let statModulesFromCache = 0;`
`3196`	`3199`	`let statModulesGenerated = 0;`
`3197`	`3200`	`const { chunkGraph, moduleGraph, dependencyTemplates, runtimeTemplate } =`