Merge pull request #14774 from tanhauhau/tanhauhau/reuse-name-variable-in-shared-scope

sokra · web-flow · commit b854db4db85c · 2021-11-26T09:22:49.000+01:00
reuse name variable in share scope
diff --git a/lib/container/ContainerEntryModule.js b/lib/container/ContainerEntryModule.js
@@ -220,10 +220,8 @@ class ContainerEntryModule extends Module {
 			])};`,
 			`var init = ${runtimeTemplate.basicFunction("shareScope, initScope", [
 				`if (!${RuntimeGlobals.shareScopeMap}) return;`,
-				`var oldScope = ${RuntimeGlobals.shareScopeMap}[${JSON.stringify(
-					this._shareScope
-				)}];`,
 				`var name = ${JSON.stringify(this._shareScope)}`,
+				`var oldScope = ${RuntimeGlobals.shareScopeMap}[name];`,
 				`if(oldScope && oldScope !== shareScope) throw new Error("Container initialization failed as it has already been initialized with a different share scope");`,
 				`${RuntimeGlobals.shareScopeMap}[name] = shareScope;`,
 				`return ${RuntimeGlobals.initializeSharing}(name, initScope);`
