Skip to content

Commit 98ea582

Browse files
sokrasokra
committed
watch package.json for managed directories
1 parent a2e4d20 commit 98ea582

10 files changed

Lines changed: 33 additions & 4 deletions

File tree

‎lib/FileSystemInfo.js‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1993,6 +1993,7 @@ class FileSystemInfo {
19931993
if (managedItem) {
19941994
managedItems.add(managedItem);
19951995
managedSet.add(path);
1996+
managedFiles.add(join(this.fs, managedItem, "package.json"));
19961997
return true;
19971998
}
19981999
}
@@ -2003,6 +2004,7 @@ class FileSystemInfo {
20032004
if (managedItem) {
20042005
managedItems.add(managedItem);
20052006
managedSet.add(path);
2007+
managedFiles.add(join(this.fs, managedItem, "package.json"));
20062008
return true;
20072009
}
20082010
}

‎test/configCases/cache-dependencies/managed-items/webpack.config.js‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,5 @@ module.exports = {
2323
expect(fileDeps).toContain(path.resolve(__dirname, "index.js"));
2424
});
2525
}
26-
],
27-
module: {
28-
unsafeCache: false
29-
}
26+
]
3027
};

‎test/watchCases/cache/unsafe-cache-managed-paths/0/index.js‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
import value from "package";
2+
3+
it("should detect updates of managed paths when version changes", () => {
4+
expect(value).toBe(WATCH_STEP);
5+
});

‎test/watchCases/cache/unsafe-cache-managed-paths/0/node_modules/package/index.js‎

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎test/watchCases/cache/unsafe-cache-managed-paths/0/node_modules/package/package.json‎

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎test/watchCases/cache/unsafe-cache-managed-paths/1/node_modules/package/index.js‎

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎test/watchCases/cache/unsafe-cache-managed-paths/1/node_modules/package/package.json‎

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎test/watchCases/cache/unsafe-cache-managed-paths/2/node_modules/package/index.js‎

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎test/watchCases/cache/unsafe-cache-managed-paths/2/node_modules/package/package.json‎

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎test/watchCases/cache/unsafe-cache-managed-paths/webpack.config.js‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
/** @type {function(): import("../../../../").Configuration} */
2+
module.exports = (env, { srcPath }) => ({
3+
mode: "development",
4+
cache: {
5+
type: "memory"
6+
},
7+
snapshot: {
8+
managedPaths: [/^(.+?[\\/]node_modules[\\/])/]
9+
}
10+
});

0 commit comments

Comments
 (0)