Merge pull request #15437 from webpack/fix/issue-11871

sokra · web-flow · commit 90c1c8adffb3 · 2022-02-28T08:17:26.000+01:00
fix imports order
diff --git a/lib/dependencies/HarmonyExportInitFragment.js b/lib/dependencies/HarmonyExportInitFragment.js
@@ -145,7 +145,10 @@ class HarmonyExportInitFragment extends InitFragment {
 				? `/* unused harmony export ${first(this.unusedExports)} */\n`
 				: "";
 		const definitions = [];
-		for (const [key, value] of this.exportMap) {
+		const orderedExportMap = Array.from(this.exportMap).sort(([a], [b]) =>
+			a < b ? -1 : 1
+		);
+		for (const [key, value] of orderedExportMap) {
 			definitions.push(
 				`\n/* harmony export */   ${JSON.stringify(
 					key
diff --git a/test/configCases/issues/issue-11871-imports-order/a.js b/test/configCases/issues/issue-11871-imports-order/a.js
@@ -0,0 +1,4 @@
+export const W = "w";
+export const A = "a";
+export const a = "a";
+export const _12 = "12";
diff --git a/test/configCases/issues/issue-11871-imports-order/index.js b/test/configCases/issues/issue-11871-imports-order/index.js
@@ -0,0 +1,5 @@
+import * as values from "./a.js";
+
+it("imports should have correct order", () => {
+	expect(Object.keys(values)).toEqual(["A", "W", "_12", "a"])
+});
diff --git a/test/configCases/issues/issue-11871-imports-order/webpack.config.js b/test/configCases/issues/issue-11871-imports-order/webpack.config.js
@@ -0,0 +1,23 @@
+"use strict";
+
+/** @type {import("../../../../").Configuration[]} */
+module.exports = [
+	{
+		mode: "development"
+	},
+	{
+		mode: "production"
+	},
+	{
+		mode: "production",
+		optimization: {
+			concatenateModules: false
+		}
+	},
+	{
+		mode: "development",
+		optimization: {
+			concatenateModules: true
+		}
+	}
+];
