Merge pull request #15404 from webpack/fix/issue-15401

sokra · web-flow · commit 378d8c8ce578 · 2022-02-22T12:30:44.000+01:00
disallow global renaming in NodeStuffPlugin
diff --git a/lib/NodeStuffPlugin.js b/lib/NodeStuffPlugin.js
@@ -69,6 +69,16 @@ class NodeStuffPlugin {
 									);
 								}
 							});
+						parser.hooks.rename.for("global").tap("NodeStuffPlugin", expr => {
+							const dep = new ConstDependency(
+								RuntimeGlobals.global,
+								expr.range,
+								[RuntimeGlobals.global]
+							);
+							dep.loc = expr.loc;
+							parser.state.module.addPresentationalDependency(dep);
+							return false;
+						});
 					}
 
 					const setModuleConstant = (expressionName, fn, warning) => {
diff --git a/test/configCases/web/node-source-global/index.js b/test/configCases/web/node-source-global/index.js
@@ -0,0 +1,9 @@
+it("should disallow rename global", () => {
+	var shouldBeGlobal = global;
+	// prevent optimizations
+	var method = shouldBeGlobal[String.fromCharCode(40, 40, 40)];
+	method && method();
+	eval("expect(shouldBeGlobal.value1).toBe('value1')");
+	expect(shouldBeGlobal.test).toBe("test");
+	expect(global.test).toBe("test");
+});
diff --git a/test/configCases/web/node-source-global/test.config.js b/test/configCases/web/node-source-global/test.config.js
@@ -0,0 +1,8 @@
+module.exports = {
+	moduleScope(scope) {
+		scope.global = scope.global || {};
+		scope.global.value1 = "error";
+		scope.globalThis = scope.globalThis || {};
+		scope.globalThis.value1 = "value1";
+	}
+};
diff --git a/test/configCases/web/node-source-global/webpack.config.js b/test/configCases/web/node-source-global/webpack.config.js
@@ -0,0 +1,13 @@
+const { DefinePlugin } = require("../../../../");
+
+/** @type {import("../../../../").Configuration} */
+module.exports = {
+	node: {
+		global: true
+	},
+	plugins: [
+		new DefinePlugin({
+			"global.test": "'test'"
+		})
+	]
+};
