Don't leak OkHttp response when response.body() is null (OpenFeign#556)

jfuerth · adriancole · commit 0444e23b0d43 · 2017-05-03T15:51:31.000+08:00
Signed-off-by: Jonathan Fuerth &lt;jonathan@helpful.com&gt;
diff --git a/okhttp/src/main/java/feign/okhttp/OkHttpClient.java b/okhttp/src/main/java/feign/okhttp/OkHttpClient.java
@@ -25,7 +25,6 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.io.Reader;
-import java.util.Arrays;
 import java.util.Collection;
 import java.util.Map;
 import java.util.concurrent.TimeUnit;
@@ -106,6 +105,9 @@ private static Map<String, Collection<String>> toMap(Headers headers) {
 
   private static feign.Response.Body toBody(final ResponseBody input) throws IOException {
     if (input == null || input.contentLength() == 0) {
+      if (input != null) {
+        input.close();
+      }
       return null;
     }
     final Integer length = input.contentLength() >= 0 && input.contentLength() <= Integer.MAX_VALUE ?
