Skip to content

Commit dc92816

Browse files
natechapinchromium-wpt-export-bot
authored andcommitted
Reland "Ensure AbortSignal.throwIfAborted doesn't modify the message of an abort error"
This reverts commit 74320221ad24d0050a8baa031ca1d0e998ea7fc6. Reason for revert: Not the cause of issues.chromium.org/issues/393009392 Original change's description: > Revert "Ensure AbortSignal.throwIfAborted doesn't modify the message of an abort error" > > This reverts commit 0e0ef178e05e3f81b0de04c8f0197fe3ab608f41. > > Reason for revert: Possible culprit for windows builder closure, see https://g-issues.chromium.org/issues/393009392. > > Original change's description: > > Ensure AbortSignal.throwIfAborted doesn't modify the message of an abort error > > > > Fixed: 392413688 > > Change-Id: I3639c573cd7349eac1f9b09c427a5a52bccdda72 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6209470 > > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > > Commit-Queue: Nate Chapin <japhet@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1412605} > > Change-Id: Ifb785338a85e77e845a677940fc1353b74757b0f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6211537 > Commit-Queue: Patti Lor <patricialor@chromium.org> > Owners-Override: Patti Lor <patricialor@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Reviewed-by: Patti Lor <patricialor@chromium.org> > Auto-Submit: Patti Lor <patricialor@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1412694} Change-Id: Ic42d7631d3ebe6a1c902e0763fdc3335f5262b33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6221802 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/main@{#1414549}
1 parent 1630698 commit dc92816

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

dom/abort/event.any.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -143,9 +143,12 @@ test(t => {
143143

144144
test(t => {
145145
const reason = new Error('boom');
146+
const message = reason.message;
146147
const signal = AbortSignal.abort(reason);
147148
assert_true(signal.aborted);
148149
assert_throws_exactly(reason, () => signal.throwIfAborted());
150+
assert_equals(reason.message, message,
151+
"abort.reason should not be changed by throwIfAborted()");
149152
}, "throwIfAborted() should throw abort.reason if signal aborted");
150153

151154
test(t => {

0 commit comments

Comments
 (0)