Add missing import and fix documentation of wrapped methods

gvalkov · gvalkov · commit a83226409f75 · 2016-02-03T01:22:42.000+01:00
diff --git a/evdev/device.py b/evdev/device.py
@@ -2,9 +2,9 @@
 
 import os
 import fcntl
-
-from select import select
-from collections import namedtuple
+import functools
+import select
+import collections
 
 from evdev import _input, _uinput, ecodes, util
 from evdev.events import InputEvent
@@ -15,9 +15,14 @@ class EvdevError(Exception):
     pass
 
 #--------------------------------------------------------------------------
-_AbsInfo = namedtuple('AbsInfo', ['value', 'min', 'max', 'fuzz', 'flat', 'resolution'])
-_KbdInfo = namedtuple('KbdInfo', ['repeat', 'delay'])
-_DeviceInfo = namedtuple('DeviceInfo', ['bustype', 'vendor', 'product', 'version'])
+_AbsInfo = collections.namedtuple(
+    'AbsInfo', ['value', 'min', 'max', 'fuzz', 'flat', 'resolution'])
+
+_KbdInfo = collections.namedtuple(
+    'KbdInfo', ['repeat', 'delay'])
+
+_DeviceInfo = collections.namedtuple(
+    'DeviceInfo', ['bustype', 'vendor', 'product', 'version'])
 
 
 class AbsInfo(_AbsInfo):
@@ -219,6 +224,7 @@ def need_write(func):
         Decorator that raises :class:`EvdevError` if there is no write access to the
         input device.
         '''
+        @functools.wraps(func)
         def wrapper(*args):
             fd = args[0].fd
             if fcntl.fcntl(fd, fcntl.F_GETFL) & os.O_RDWR:
diff --git a/evdev/uinput.py b/evdev/uinput.py
@@ -3,6 +3,7 @@
 import os
 import stat
 import time
+import select
 
 from evdev import _input, _uinput
 from evdev import ecodes, util, device
@@ -160,7 +161,7 @@ def read_loop(self):
         '''
 
         while True:
-            r, w, x = select([self.fd], [], [])
+            r, w, x = select.select([self.fd], [], [])
             for event in self.read():
                 yield event
 
