fix: address review feedback for unsaved changes warning

majiayu000 · majiayu000 · commit 7dc37453e486 · 2026-03-21T12:26:18.000+08:00
- Simplify Visual tab guard by removing redundant activeTab check
  (confirmDiscardChanges already returns true when no changes exist)
- Document intentional asymmetry: JSON tab button has no guard because
  visual tab saves changes immediately via RPC

Signed-off-by: majiayu000 &lt;1835304752@qq.com&gt;
diff --git a/frontend/app/view/waveconfig/waveconfig.tsx b/frontend/app/view/waveconfig/waveconfig.tsx
@@ -231,7 +231,7 @@ const WaveConfigView = memo(({ blockId, model }: ViewComponentProps<WaveConfigVi
                             <div className="flex gap-0 border-b border-border">
                                 <button
                                     onClick={() => {
-                                        if (activeTab === "json" && !model.confirmDiscardChanges()) return;
+                                        if (!model.confirmDiscardChanges()) return;
                                         setActiveTab("visual");
                                     }}
                                     className={cn(
@@ -243,6 +243,7 @@ const WaveConfigView = memo(({ blockId, model }: ViewComponentProps<WaveConfigVi
                                 >
                                     Visual
                                 </button>
+                                {/* No guard needed: visual tab saves changes immediately via RPC */}
                                 <button
                                     onClick={() => setActiveTab("json")}
                                     className={cn(
