fix: Patch to resolve issue #13#14
Merged
Merged
Conversation
added 2 commits
November 2, 2020 23:00
Added error handler for file creation failure
germanattanasio
approved these changes
Nov 9, 2020
|
🎉 This PR is included in version 1.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like @mamoonraja did, I've experienced the
502 Bad gatewayerror frequently on https://visual-recognition-code-pattern.ng.bluemix.net/ when I uploaded images. However, it works fine when I choose the example image packaged in application code!So, I doubted if this is happening when there was a problem creating the image file in the Cloud Foundry runtime. After I review the code i knew that there is no error handler for creating temporary files and it does not remove temporary files after use.
In this PR, I added the error handler and the code to remove the temporary file.
Thanks.