touchups

kyclark · kyclark · commit e07791bdc5dc · 2020-04-18T15:15:07.000-07:00
diff --git a/14_rhymer/solution1_regex.py b/14_rhymer/solution1_regex.py
@@ -14,7 +14,7 @@ def get_args():
         description='Make rhyming "words"',
         formatter_class=argparse.ArgumentDefaultsHelpFormatter)
 
-    parser.add_argument('word', metavar='str', help='A word to rhyme')
+    parser.add_argument('word', metavar='word', help='A word to rhyme')
 
     return parser.parse_args()
 
diff --git a/21_tictactoe/solution1.py b/21_tictactoe/solution1.py
@@ -56,11 +56,9 @@ def main():
 
     args = get_args()
     board = list(args.board)
-    player = args.player
-    cell = args.cell
 
-    if player and cell:
-        board[cell - 1] = player
+    if args.player and args.cell:
+        board[args.cell - 1] = args.player
 
     print(format_board(board))
     winner = find_winner(board)
diff --git a/21_tictactoe/solution2.py b/21_tictactoe/solution2.py
@@ -56,11 +56,9 @@ def main():
 
     args = get_args()
     board = list(args.board)
-    player = args.player
-    cell = args.cell
 
-    if player and cell:
-        board[cell - 1] = player
+    if args.player and args.cell:
+        board[args.cell - 1] = args.player
 
     print(format_board(board))
     winner = find_winner(board)
diff --git a/21_tictactoe/unit.py b/21_tictactoe/unit.py
@@ -63,6 +63,6 @@ def test_losing():
 
     losing_board = list('XXOO.....')
 
-    for i in range(10):
+    for _ in range(10):
         random.shuffle(losing_board)
-        assert find_winner(''.join(losing_board)) == None
+        assert find_winner(''.join(losing_board)) is None
