PythonDebugger: testing EOF on the stream is not always reliable

spillz · spillz · commit 0f7ef7105b57 · 2015-02-02T16:15:08.000-05:00
diff --git a/PythonDebugger/PythonDebugger.cpp b/PythonDebugger/PythonDebugger.cpp
@@ -252,10 +252,11 @@ void PythonDebugger::OnTimer(wxTimerEvent& event)
     {
         while(m_pp->IsInputAvailable())
         {
-            if(!m_istream->Eof())
-                m_outbuf+=m_istream->GetC();
-            else
-                break;
+            int c;
+            if (m_istream->CanRead())
+                c = m_istream->GetC();
+            if (m_istream->LastRead()>0)
+                m_outbuf += c;
         }
         //TODO: Program could hang if debug output is incorrectly parsed
         m_outdebugbuf=m_outbuf;

Original file line number	Diff line number	Diff line change
`@@ -252,10 +252,11 @@ void PythonDebugger::OnTimer(wxTimerEvent& event)`
`252`	`252`	`{`
`253`	`253`	`while(m_pp->IsInputAvailable())`
`254`	`254`	`{`
`255`		`- if(!m_istream->Eof())`
`256`		`- m_outbuf+=m_istream->GetC();`
`257`		`- else`
`258`		`- break;`
	`255`	`+ int c;`
	`256`	`+ if (m_istream->CanRead())`
	`257`	`+ c = m_istream->GetC();`
	`258`	`+ if (m_istream->LastRead()>0)`
	`259`	`+ m_outbuf += c;`
`259`	`260`	`}`
`260`	`261`	`//TODO: Program could hang if debug output is incorrectly parsed`
`261`	`262`	`m_outdebugbuf=m_outbuf;`