Skip to content

Sandboxing steps in start, reconnect, getAvailability are now useless #398

Closed

Description

@tidoust

Now that the PresentationRequest constructing steps also check sandboxing flags, I do not see any way to get into a situation where these flags need to be checked again in start, reconnect, or getAvailability.

When we discussed that, I thought sandboxing flag attributes could be changed on-the-fly. I was wrong, there is a warning in HTML5 which says: "These flags only take effect when the nested browsing context of the iframe is navigated. Removing them, or removing the entire sandbox attribute, has no effect on an already-loaded page":
http://www.w3.org/TR/html51/semantics-embedded-content.html#element-attrdef-iframe-sandbox

Now, these steps are essentially harmless, so we could leave them. They are just no-op in practice and could be dropped.

Activity

  1. markafoltz commented on Dec 22, 2016

    @markafoltz
    Contributor

    Addressed by PR #399.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions