Skip to content

Commit 075ce83

Browse files
vschvsch
committed
cleanup of tests
1 parent 6ff1c4d commit 075ce83

301 files changed

Lines changed: 1726 additions & 28481 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.idea/codeStyles/Project.xml‎

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎.idea/compiler.xml‎

Lines changed: 3 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎.idea/modules.xml‎

Lines changed: 1 addition & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎.idea/scopes/Extension_Modules.xml‎

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎.idea/scopes/Flexmark_Ext_Overview.xml‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎VERSION.md‎

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -116,9 +116,8 @@ Please give feedback on the upcoming changes if you have concerns about breaking
116116
have these annotations for analysis of potential problems and use with Kotlin.
117117
* [x] Break: refactor and cleanup tests to eliminate duplicated code and allow easier reuse of
118118
test cases with spec example data.
119-
* [x] Break: move formatter tests to `flexmark-formatter-test` module to allow sharing of
120-
formatter base classes in extensions without causing dependency cycles in formatter
121-
module.
119+
* [x] Break: move formatter tests to `flexmark-core-test` module to allow sharing of formatter
120+
base classes in extensions without causing dependency cycles in formatter module.
122121
* [x] Break: move formatter module into `flexmark` core. this module is almost always included
123122
anyway because most extension have a dependency on formatter for their custom formatting
124123
implementations. Having it as part of the core allows relying on its functionality in all
@@ -158,15 +157,27 @@ Next 0.59.15
158157
0.59.13
159158
-------
160159

161-
* Break: move formatter tests to `flexmark-formatter-test` module to allow sharing of formatter
162-
base classes in extensions without causing dependency cycles in formatter module.
160+
* Break: move formatter tests and html renderer to `flexmark-core-test` module to allow sharing
161+
of test base classes in extensions without causing dependency cycles in formatter module.
163162
* Break: move formatter module into `flexmark` core. this module is almost always included
164163
anyway because most extension have a dependency on formatter for their custom formatting
165164
implementations. Having it as part of the core allows relying on its functionality in all
166165
modules.
167166
* Break: move `com.vladsch.flexmark.spec` and `com.vladsch.flexmark.util` in
168167
`flexmark-test-util` to `com.vladsch.flexmark.test.spec` and `com.vladsch.flexmark.test.util`
169168
respectively to respect the naming convention between modules and their packages.
169+
* Break: remove `flexmark-html-parser`, `flexmark-html2md-converter` is a replacement
170+
* Fix: revert back to `MutableDataSet.set(DataKey<T>, T)` to enforce compile time type checking
171+
for typed class values
172+
* Fix: clean up all tests to eliminate duplication and unnecessary interface methods.
173+
174+
| Metric | Before | After |
175+
|---------------|--------:|--------:|
176+
| Files | 1264 | 1297 |
177+
| Lines | 124,192 | 118,755 |
178+
| Source Lines | 96,669 | 92,145 |
179+
| Comment Lines | 9,878 | 9,597 |
180+
| Blank Lines | 17,646 | 17,013 |
170181

171182
### 0.59.11
172183

‎flexmark-all/flexmark-all.iml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@
4949
<orderEntry type="module" module-name="flexmark-ext-yaml-front-matter" />
5050
<orderEntry type="module" module-name="flexmark-ext-youtube-embedded" />
5151
<orderEntry type="module" module-name="flexmark-formatter-test-suite" />
52-
<orderEntry type="module" module-name="flexmark-html-parser" />
5352
<orderEntry type="module" module-name="flexmark-html2md-converter" />
5453
<orderEntry type="module" module-name="flexmark-integration-test" />
5554
<orderEntry type="module" module-name="flexmark-java-samples" />

‎flexmark-all/pom.xml‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -173,11 +173,6 @@
173173
<artifactId>flexmark-ext-youtube-embedded</artifactId>
174174
<version>0.60.0</version>
175175
</dependency>
176-
<dependency>
177-
<groupId>com.vladsch.flexmark</groupId>
178-
<artifactId>flexmark-html-parser</artifactId>
179-
<version>0.60.0</version>
180-
</dependency>
181176
<dependency>
182177
<groupId>com.vladsch.flexmark</groupId>
183178
<artifactId>flexmark-html2md-converter</artifactId>

‎flexmark-all/src/assembly/bin.xml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242
<include>com.vladsch.flexmark:flexmark-ext-wikilink</include>
4343
<include>com.vladsch.flexmark:flexmark-ext-yaml-front-matter</include>
4444
<include>com.vladsch.flexmark:flexmark-ext-youtube-embedded</include>
45-
<include>com.vladsch.flexmark:flexmark-html-parser</include>
4645
<include>com.vladsch.flexmark:flexmark-jira-converter</include>
4746
<include>com.vladsch.flexmark:flexmark-pdf-converter</include>
4847
<include>com.vladsch.flexmark:flexmark-youtrack-converter</include>

flexmark-formatter-test/flexmark-formatter-test.iml renamed to flexmark-core-test/flexmark-core-test.iml

File renamed without changes.

0 commit comments

Comments
 (0)