Skip to content

High level C Scan API#7212

Merged
myrrc merged 1 commit intodevelopfrom
myrrc/scan-ffi
Apr 17, 2026
Merged

High level C Scan API#7212
myrrc merged 1 commit intodevelopfrom
myrrc/scan-ffi

Conversation

@myrrc
Copy link
Copy Markdown
Contributor

@myrrc myrrc commented Mar 31, 2026

Expose data source, partition, and scan primitives through C with rust-side and C-side tests.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 31, 2026

Merging this PR will not alter performance

✅ 1163 untouched benchmarks
⏩ 1457 skipped benchmarks1


Comparing myrrc/scan-ffi (b841add) with develop (cd798b3)

Open in CodSpeed

Footnotes

  1. 1457 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@myrrc myrrc requested a review from gatesn March 31, 2026 15:02
@myrrc myrrc changed the title High level scan api draft High level C Scan API Apr 1, 2026
@myrrc myrrc requested a review from 0ax1 April 8, 2026 14:51
Comment thread vortex-ffi/cinclude/vortex.h
Comment thread vortex-ffi/cinclude/vortex.h
Comment thread vortex-ffi/cinclude/vortex.h Outdated
Comment thread vortex-ffi/cinclude/vortex.h
Comment thread vortex-ffi/cinclude/vortex.h
Comment thread vortex-ffi/cinclude/vortex.h
Comment thread vortex-ffi/src/scan.rs Outdated
Comment thread vortex-ffi/src/scan.rs Outdated
Comment thread vortex-ffi/src/scan.rs Outdated
Comment thread vortex-ffi/src/scan.rs
Comment thread vortex-ffi/src/scan.rs
Comment thread vortex-ffi/src/scan.rs
Comment thread vortex-ffi/cbindgen.toml
Comment thread vortex-ffi/CMakeLists.txt Outdated
Comment thread vortex-ffi/src/scan.rs
Comment thread vortex-ffi/src/scan.rs
Comment thread vortex-ffi/src/scan.rs
Comment thread vortex-ffi/src/data_source.rs
Comment thread vortex-ffi/src/scan.rs
Copy link
Copy Markdown
Contributor

@0ax1 0ax1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should prob consider putting #[deny(missing_docs)] for ffi on a module level.

Comment thread vortex-ffi/test/scan.cpp Outdated
Comment thread vortex-ffi/src/data_source.rs Outdated
Comment thread vortex-ffi/src/scan.rs
Comment thread vortex-ffi/src/scan.rs
Comment thread vortex-ffi/test/scan.cpp Outdated
@myrrc myrrc force-pushed the myrrc/scan-ffi branch 2 times, most recently from 445319f to ec9a3f3 Compare April 13, 2026 08:59
@myrrc myrrc added the changelog/feature A new feature label Apr 13, 2026
@myrrc myrrc marked this pull request as ready for review April 16, 2026 15:19
@0ax1 0ax1 requested review from 0ax1 and gatesn April 16, 2026 15:20
@myrrc myrrc enabled auto-merge (squash) April 16, 2026 15:34
@myrrc myrrc force-pushed the myrrc/scan-ffi branch 2 times, most recently from 26d97d2 to 9483918 Compare April 17, 2026 09:32
Signed-off-by: Mikhail Kot <to@myrrc.dev>
@myrrc myrrc merged commit 6a2d4ad into develop Apr 17, 2026
59 of 60 checks passed
@myrrc myrrc deleted the myrrc/scan-ffi branch April 17, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/feature A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants