Unify id creation for ScalarFns and rename is_null to vortex.is_null (#7325)

robert3005 · web-flow · commit 5adc4374e11b · 2026-04-08T10:47:06.000-04:00
Use ScalarFnId::from instead of new_ref and rename is_null fn to
vortex.is_null

Signed-off-by: Robert Kruszewski &lt;github@robertk.io&gt;
diff --git a/vortex-array/src/scalar_fn/fns/dynamic.rs b/vortex-array/src/scalar_fn/fns/dynamic.rs
@@ -46,7 +46,7 @@ impl ScalarFnVTable for DynamicComparison {
     type Options = DynamicComparisonExpr;
 
     fn id(&self) -> ScalarFnId {
-        ScalarFnId::new_ref("vortex.dynamic")
+        ScalarFnId::from("vortex.dynamic")
     }
 
     fn arity(&self, _options: &Self::Options) -> Arity {
diff --git a/vortex-array/src/scalar_fn/fns/is_null.rs b/vortex-array/src/scalar_fn/fns/is_null.rs
@@ -34,7 +34,7 @@ impl ScalarFnVTable for IsNull {
     type Options = EmptyOptions;
 
     fn id(&self) -> ScalarFnId {
-        ScalarFnId::new_ref("is_null")
+        ScalarFnId::from("vortex.is_null")
     }
 
     fn serialize(&self, _instance: &Self::Options) -> VortexResult<Option<Vec<u8>>> {
diff --git a/vortex-array/src/scalar_fn/fns/literal.rs b/vortex-array/src/scalar_fn/fns/literal.rs
@@ -38,7 +38,7 @@ impl ScalarFnVTable for Literal {
     type Options = Scalar;
 
     fn id(&self) -> ScalarFnId {
-        ScalarFnId::new_ref("vortex.literal")
+        ScalarFnId::from("vortex.literal")
     }
 
     fn serialize(&self, instance: &Self::Options) -> VortexResult<Option<Vec<u8>>> {
diff --git a/vortex-array/src/scalar_fn/fns/merge.rs b/vortex-array/src/scalar_fn/fns/merge.rs
@@ -51,7 +51,7 @@ impl ScalarFnVTable for Merge {
     type Options = DuplicateHandling;
 
     fn id(&self) -> ScalarFnId {
-        ScalarFnId::new_ref("vortex.merge")
+        ScalarFnId::from("vortex.merge")
     }
 
     fn serialize(&self, instance: &Self::Options) -> VortexResult<Option<Vec<u8>>> {
diff --git a/vortex-array/src/scalar_fn/fns/pack.rs b/vortex-array/src/scalar_fn/fns/pack.rs
@@ -54,7 +54,7 @@ impl ScalarFnVTable for Pack {
     type Options = PackOptions;
 
     fn id(&self) -> ScalarFnId {
-        ScalarFnId::new_ref("vortex.pack")
+        ScalarFnId::from("vortex.pack")
     }
 
     fn serialize(&self, instance: &Self::Options) -> VortexResult<Option<Vec<u8>>> {
diff --git a/vortex-array/src/scalar_fn/fns/select.rs b/vortex-array/src/scalar_fn/fns/select.rs
@@ -48,7 +48,7 @@ impl ScalarFnVTable for Select {
     type Options = FieldSelection;
 
     fn id(&self) -> ScalarFnId {
-        ScalarFnId::new_ref("vortex.select")
+        ScalarFnId::from("vortex.select")
     }
 
     fn serialize(&self, instance: &FieldSelection) -> VortexResult<Option<Vec<u8>>> {
diff --git a/vortex-tensor/src/scalar_fns/cosine_similarity.rs b/vortex-tensor/src/scalar_fns/cosine_similarity.rs
@@ -74,7 +74,7 @@ impl ScalarFnVTable for CosineSimilarity {
     type Options = ApproxOptions;
 
     fn id(&self) -> ScalarFnId {
-        ScalarFnId::new_ref("vortex.tensor.cosine_similarity")
+        ScalarFnId::from("vortex.tensor.cosine_similarity")
     }
 
     fn arity(&self, _options: &Self::Options) -> Arity {
diff --git a/vortex-tensor/src/scalar_fns/inner_product.rs b/vortex-tensor/src/scalar_fns/inner_product.rs
@@ -77,7 +77,7 @@ impl ScalarFnVTable for InnerProduct {
     type Options = ApproxOptions;
 
     fn id(&self) -> ScalarFnId {
-        ScalarFnId::new_ref("vortex.tensor.inner_product")
+        ScalarFnId::from("vortex.tensor.inner_product")
     }
 
     fn arity(&self, _options: &Self::Options) -> Arity {
diff --git a/vortex-tensor/src/scalar_fns/l2_norm.rs b/vortex-tensor/src/scalar_fns/l2_norm.rs
@@ -71,7 +71,7 @@ impl ScalarFnVTable for L2Norm {
     type Options = ApproxOptions;
 
     fn id(&self) -> ScalarFnId {
-        ScalarFnId::new_ref("vortex.tensor.l2_norm")
+        ScalarFnId::from("vortex.tensor.l2_norm")
     }
 
     fn arity(&self, _options: &Self::Options) -> Arity {

Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ impl ScalarFnVTable for DynamicComparison {`
`46`	`46`	`type Options = DynamicComparisonExpr;`
`47`	`47`
`48`	`48`	`fn id(&self) -> ScalarFnId {`
`49`		`- ScalarFnId::new_ref("vortex.dynamic")`
	`49`	`+ ScalarFnId::from("vortex.dynamic")`
`50`	`50`	`}`
`51`	`51`
`52`	`52`	`fn arity(&self, _options: &Self::Options) -> Arity {`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ impl ScalarFnVTable for IsNull {`
`34`	`34`	`type Options = EmptyOptions;`
`35`	`35`
`36`	`36`	`fn id(&self) -> ScalarFnId {`
`37`		`- ScalarFnId::new_ref("is_null")`
	`37`	`+ ScalarFnId::from("vortex.is_null")`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`fn serialize(&self, _instance: &Self::Options) -> VortexResult<Option<Vec<u8>>> {`
Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ impl ScalarFnVTable for Literal {`
`38`	`38`	`type Options = Scalar;`
`39`	`39`
`40`	`40`	`fn id(&self) -> ScalarFnId {`
`41`		`- ScalarFnId::new_ref("vortex.literal")`
	`41`	`+ ScalarFnId::from("vortex.literal")`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`fn serialize(&self, instance: &Self::Options) -> VortexResult<Option<Vec<u8>>> {`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ impl ScalarFnVTable for Merge {`
`51`	`51`	`type Options = DuplicateHandling;`
`52`	`52`
`53`	`53`	`fn id(&self) -> ScalarFnId {`
`54`		`- ScalarFnId::new_ref("vortex.merge")`
	`54`	`+ ScalarFnId::from("vortex.merge")`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`fn serialize(&self, instance: &Self::Options) -> VortexResult<Option<Vec<u8>>> {`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ impl ScalarFnVTable for Pack {`
`54`	`54`	`type Options = PackOptions;`
`55`	`55`
`56`	`56`	`fn id(&self) -> ScalarFnId {`
`57`		`- ScalarFnId::new_ref("vortex.pack")`
	`57`	`+ ScalarFnId::from("vortex.pack")`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`fn serialize(&self, instance: &Self::Options) -> VortexResult<Option<Vec<u8>>> {`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ impl ScalarFnVTable for Select {`
`48`	`48`	`type Options = FieldSelection;`
`49`	`49`
`50`	`50`	`fn id(&self) -> ScalarFnId {`
`51`		`- ScalarFnId::new_ref("vortex.select")`
	`51`	`+ ScalarFnId::from("vortex.select")`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`fn serialize(&self, instance: &FieldSelection) -> VortexResult<Option<Vec<u8>>> {`
Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ impl ScalarFnVTable for CosineSimilarity {`
`74`	`74`	`type Options = ApproxOptions;`
`75`	`75`
`76`	`76`	`fn id(&self) -> ScalarFnId {`
`77`		`- ScalarFnId::new_ref("vortex.tensor.cosine_similarity")`
	`77`	`+ ScalarFnId::from("vortex.tensor.cosine_similarity")`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`fn arity(&self, _options: &Self::Options) -> Arity {`
Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ impl ScalarFnVTable for InnerProduct {`
`77`	`77`	`type Options = ApproxOptions;`
`78`	`78`
`79`	`79`	`fn id(&self) -> ScalarFnId {`
`80`		`- ScalarFnId::new_ref("vortex.tensor.inner_product")`
	`80`	`+ ScalarFnId::from("vortex.tensor.inner_product")`
`81`	`81`	`}`
`82`	`82`
`83`	`83`	`fn arity(&self, _options: &Self::Options) -> Arity {`
Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ impl ScalarFnVTable for L2Norm {`
`71`	`71`	`type Options = ApproxOptions;`
`72`	`72`
`73`	`73`	`fn id(&self) -> ScalarFnId {`
`74`		`- ScalarFnId::new_ref("vortex.tensor.l2_norm")`
	`74`	`+ ScalarFnId::from("vortex.tensor.l2_norm")`
`75`	`75`	`}`
`76`	`76`
`77`	`77`	`fn arity(&self, _options: &Self::Options) -> Arity {`