Skip to content

Commit 83a7a91

Browse files
committed
Fix TODOs in writev
1 parent 41c65cb commit 83a7a91

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

src/node_io_watcher.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -295,8 +295,8 @@ void IOWatcher::Dump(EV_P_ ev_prepare *watcher, int revents) {
295295
Local<Object> buf_object;
296296

297297
if (data_v->IsString()) {
298-
// FIXME This is suboptimal - Buffer::New is slow.
299-
// Also insert v8::String::Pointers() hack here.
298+
// TODO: insert v8::String::Pointers() hack here.
299+
// TODO: handle different encodings.
300300
Local<String> s = data_v->ToString();
301301
buf_object = Local<Object>::New(Buffer::New(s));
302302
bucket->Set(data_sym, buf_object);

0 commit comments

Comments
 (0)