Skip to content

Commit d804113

Browse files
thibaultmeyerthibaultmeyer
committed
Fix some SonarQube issues
Signed-off-by: Thibault Meyer <meyer.thibault@gmail.com>
1 parent da50094 commit d804113

File tree

19 files changed

+79
-38
lines changed

19 files changed

+79
-38
lines changed

‎voidframework-cache/src/test/java/dev/voidframework/cache/module/CacheInterceptorTest.java‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,8 @@ public String doSomethingKeyWithArgs(final String id) {
184184

185185
@CacheRemove(key = "{class}.key.{0}")
186186
void removeCache(final String id) {
187+
188+
// Nothing to do
187189
}
188190
}
189191
}

‎voidframework-core/src/main/java/dev/voidframework/core/utils/ReflectionUtils.java‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ public static <T> T getFieldValue(final Object classInstance,
8989

9090
try {
9191
final Field field = classInstance.getClass().getDeclaredField(fieldName);
92-
field.setAccessible(true);
92+
field.setAccessible(true); // NOSONAR "Accessibility update is necessary"
9393

9494
return valueTypeClass.cast(field.get(classInstance));
9595
} catch (final Exception ex) {
@@ -114,7 +114,7 @@ public static <T> T getFieldValue(final Object classInstance,
114114

115115
try {
116116
final Field field = classInstance.getClass().getDeclaredField(fieldName);
117-
field.setAccessible(true);
117+
field.setAccessible(true); // NOSONAR "Accessibility update is necessary"
118118

119119
return wrappedClass.getWrappedClass().cast(field.get(classInstance));
120120
} catch (final Exception ex) {
@@ -137,9 +137,9 @@ public static void setFieldValue(final Object classInstance,
137137

138138
try {
139139
final Field field = classInstance.getClass().getDeclaredField(fieldName);
140-
field.setAccessible(true);
141-
field.set(classInstance, value);
142-
field.setAccessible(false);
140+
field.setAccessible(true); // NOSONAR "Accessibility update is necessary"
141+
field.set(classInstance, value); // NOSONAR "Accessibility update is necessary"
142+
field.setAccessible(false); // NOSONAR "Accessibility update is necessary"
143143
} catch (final Exception ex) {
144144
LOGGER.error("Can't set field value", ex);
145145
}
@@ -184,10 +184,10 @@ public static <T> T callMethod(final Object classInstance,
184184

185185
try {
186186
final Method method = classInstance.getClass().getDeclaredMethod(methodeName, argumentTypeArray);
187-
method.setAccessible(true);
187+
method.setAccessible(true); // NOSONAR "Accessibility update is necessary"
188188

189189
final T ret = returnTypeClass.cast(method.invoke(classInstance, argumentArray));
190-
method.setAccessible(false);
190+
method.setAccessible(false); // NOSONAR "Accessibility update is necessary"
191191

192192
return ret;
193193
} catch (final Exception ex) {
@@ -212,9 +212,9 @@ public static void callMethod(final Object classInstance,
212212

213213
try {
214214
final Method method = classInstance.getClass().getDeclaredMethod(methodeName, argumentTypeArray);
215-
method.setAccessible(true);
215+
method.setAccessible(true); // NOSONAR "Accessibility update is necessary"
216216
method.invoke(classInstance, argumentArray);
217-
method.setAccessible(false);
217+
method.setAccessible(false); // NOSONAR "Accessibility update is necessary"
218218
} catch (final Exception ex) {
219219
LOGGER.error("Can't call method", ex);
220220
}

‎voidframework-core/src/main/java/dev/voidframework/core/utils/XmlUtils.java‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,12 @@ public static String toString(final Document xml) {
6767

6868
final Writer writer = new StringWriter();
6969
try {
70-
TransformerFactory.newInstance()
71-
.newTransformer()
70+
final TransformerFactory factory = TransformerFactory.newInstance(); // NOSONAR "Disable access to external entities in XML parsing"
71+
factory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true);
72+
73+
factory.newTransformer()
7274
.transform(new DOMSource(xml), new StreamResult(writer));
75+
7376
writer.flush();
7477
} catch (final TransformerException | IOException ex) {
7578
throw new XmlException.ToStringConversionFailure(ex);

‎voidframework-core/src/test/java/dev/voidframework/core/jackson/CUIDDeserializerTest.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
@TestMethodOrder(MethodOrderer.MethodName.class)
1515
final class CUIDDeserializerTest {
1616

17-
private final JavaType LIST_CUID_JAVA_TYPE = JsonUtils.objectMapper().constructType(new TypeReference<List<CUID>>() {
17+
private static final JavaType LIST_CUID_JAVA_TYPE = JsonUtils.objectMapper().constructType(new TypeReference<List<CUID>>() {
1818
});
1919

2020
@Test

‎voidframework-core/src/test/java/dev/voidframework/core/lifecycle/LifeCycleTest.java‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,7 @@ public void stop() {
140140
try {
141141
Thread.sleep(15000);
142142
} catch (final InterruptedException ignore) {
143+
// Nothing to do
143144
}
144145
}
145146
}

‎voidframework-core/src/test/java/dev/voidframework/core/utils/KryoUtilsTest.java‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -146,12 +146,12 @@ void serializeWithoutException(final Object toSerialize, final byte[] expected)
146146
void serializeAndDeserializeTypedMap() {
147147

148148
// Arrange
149-
final TypedMap.Key<String> TOKEN = TypedMap.Key.of("TOKEN", String.class);
150-
final TypedMap.Key<Integer> BIRTH_YEAR = TypedMap.Key.of("B_YEAR", Integer.class);
149+
final TypedMap.Key<String> token = TypedMap.Key.of("TOKEN", String.class);
150+
final TypedMap.Key<Integer> birthYear = TypedMap.Key.of("B_YEAR", Integer.class);
151151

152152
final TypedMap typedMap = new TypedMap();
153-
typedMap.put(TOKEN, "d0944b7c-b01f-4be7-9ace-155927589a8b");
154-
typedMap.put(BIRTH_YEAR, 1742);
153+
typedMap.put(token, "d0944b7c-b01f-4be7-9ace-155927589a8b");
154+
typedMap.put(birthYear, 1742);
155155

156156
// Act
157157
final byte[] serializedContent = KryoUtils.serialize(typedMap);

‎voidframework-core/src/test/java/dev/voidframework/core/utils/ProxyDetectorUtilsTest.java‎

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,19 @@ void isProxyClass() {
4343
Assertions.assertTrue(isProxy);
4444
}
4545

46+
@Test
47+
void isProxyClassNull() {
48+
49+
// Arrange
50+
final Class<?> classType = null;
51+
52+
// Act
53+
final boolean isProxy = ProxyDetectorUtils.isProxy(classType);
54+
55+
// Assert
56+
Assertions.assertFalse(isProxy);
57+
}
58+
4659
@Test
4760
void isProxyClassNonProxyClass() {
4861

@@ -69,6 +82,19 @@ void isProxyObject() {
6982
Assertions.assertTrue(isProxy);
7083
}
7184

85+
@Test
86+
void isProxyObjectNull() {
87+
88+
// Arrange
89+
final Example proxyInstance = null;
90+
91+
// Act
92+
final boolean isProxy = ProxyDetectorUtils.isProxy(proxyInstance);
93+
94+
// Assert
95+
Assertions.assertFalse(isProxy);
96+
}
97+
7298
@Test
7399
void isProxyObjectNonProxyClass() {
74100

‎voidframework-persistence-hibernate/src/test/java/dev/voidframework/persistence/hibernate/TransactionalTest.java‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -185,6 +185,7 @@ PRIMARY KEY (id)
185185
final DummyService dummyService = this.injector.getInstance(DummyService.class);
186186
dummyService.transactionalRequiredUncheckedException();
187187
} catch (final NullPointerException ignore) {
188+
// Nothing to do
188189
}
189190

190191
final List<?> list = entityManagerProvider.get().createNativeQuery("SELECT * FROM UNIT_TEST_UNCHECKED_EX").getResultList();
@@ -213,6 +214,7 @@ PRIMARY KEY (id)
213214
final DummyService dummyService = this.injector.getInstance(DummyService.class);
214215
dummyService.transactionalRequiredCheckedException();
215216
} catch (final FileNotFoundException ignore) {
217+
// Nothing to do
216218
}
217219

218220
final List<?> list = entityManagerProvider.get().createNativeQuery("SELECT * FROM UNIT_TEST_CHECKED_EX").getResultList();

‎voidframework-persistence-jooq/src/main/java/dev/voidframework/persistence/jooq/module/TransactionalInterceptor.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -131,7 +131,7 @@ private Object proceedInTransaction(final MethodInvocation methodInvocation,
131131

132132
// Creates a new transaction and then executes the method. If something goes
133133
// wrong, and depending on the configuration, a rollback will be performed
134-
final Either<Object, Throwable> result = dslContext.transactionResult((configuration) -> {
134+
final Either<Object, Throwable> result = dslContext.transactionResult(configuration -> {
135135
try {
136136
this.dslContextProvider.replaceExistingDSLContext(configuration.dsl());
137137
return Either.ofLeft(methodInvocation.proceed());

‎voidframework-persistence-jooq/src/test/java/dev/voidframework/persistence/jooq/PersistenceJooqTest.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ void transaction() {
8989
final DSLContext dslContext = dslContextProvider.get();
9090

9191
// Act
92-
dslContext.transaction((context) -> {
92+
dslContext.transaction(context -> {
9393
context.dsl().query("""
9494
CREATE TABLE UNIT_TEST_OLD (
9595
ID VARCHAR(36) NOT NULL,
@@ -118,7 +118,7 @@ void managedEntityQuery() {
118118
final DSLContext dslContext = dslContextProvider.get();
119119

120120
// Act
121-
final int insertedCount = dslContext.transactionResult((context) -> {
121+
final int insertedCount = dslContext.transactionResult(context -> {
122122
try {
123123
context.dsl().query("""
124124
CREATE TABLE UNIT_TEST_MANAGED_ENTITY (

0 commit comments

Comments
 (0)