Clean code

thibaultmeyer · thibaultmeyer · commit 7fa980718ff8 · 2023-05-14T10:04:55.000+02:00
Signed-off-by: Thibault Meyer &lt;meyer.thibault@gmail.com&gt;
diff --git a/voidframework-cache/src/main/java/dev/voidframework/cache/annotation/CacheRemove.java b/voidframework-cache/src/main/java/dev/voidframework/cache/annotation/CacheRemove.java
@@ -29,13 +29,13 @@
      * @return Class[] of Exceptions
      * @since 1.0.1
      */
-    Class[] evictOn() default {};
+    Class<?>[] evictOn() default {};
 
     /**
      * Defines exception Classes indicating the exception types that must not cause a cache eviction.
      *
      * @return Class[] of Exceptions
      * @since 1.0.1
      */
-    Class[] noEvictOn() default {};
+    Class<?>[] noEvictOn() default {};
 }
diff --git a/voidframework-core/src/main/java/dev/voidframework/core/classestoload/ClassesToLoadScanner.java b/voidframework-core/src/main/java/dev/voidframework/core/classestoload/ClassesToLoadScanner.java
@@ -5,7 +5,6 @@
 import com.esotericsoftware.kryo.io.Output;
 import com.google.inject.AbstractModule;
 import dev.voidframework.core.bindable.Bindable;
-import dev.voidframework.core.bindable.Repository;
 import dev.voidframework.core.constant.StringConstants;
 import dev.voidframework.core.conversion.TypeConverter;
 import dev.voidframework.core.exception.ConversionException;
@@ -28,7 +27,6 @@
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
-import java.util.Map;
 import java.util.Objects;
 
 /**
diff --git a/voidframework-core/src/main/java/dev/voidframework/core/remoteconfiguration/RemoteConfigurationLoader.java b/voidframework-core/src/main/java/dev/voidframework/core/remoteconfiguration/RemoteConfigurationLoader.java
@@ -1,6 +1,7 @@
 package dev.voidframework.core.remoteconfiguration;
 
 import com.typesafe.config.Config;
+import com.typesafe.config.ConfigException;
 import com.typesafe.config.ConfigFactory;
 import dev.voidframework.core.constant.StringConstants;
 import dev.voidframework.core.exception.RemoteConfigurationException;
@@ -69,6 +70,10 @@ public static Config processAllProviders(final Config localConfiguration) {
                         }
                     }
                 }
+                default -> throw new ConfigException.BadValue(
+                    localConfiguration.origin(),
+                    CONFIGURATION_KEY_REGISTERED_PROVIDERS,
+                    "Must be a single String or a StringList");
             }
         }
 
diff --git a/voidframework-template-freemarker/src/main/java/dev/voidframework/template/freemarker/method/ConfigTemplateMethodModel.java b/voidframework-template-freemarker/src/main/java/dev/voidframework/template/freemarker/method/ConfigTemplateMethodModel.java
@@ -33,6 +33,7 @@ public ConfigTemplateMethodModel(final Config configuration) {
     }
 
     @Override
+    @SuppressWarnings("rawtypes")
     public TemplateModel exec(final List argumentList) throws TemplateModelException {
 
         if (argumentList.size() != 1) {
diff --git a/voidframework-template-freemarker/src/main/java/dev/voidframework/template/freemarker/method/InternationalizationTemplateMethodModel.java b/voidframework-template-freemarker/src/main/java/dev/voidframework/template/freemarker/method/InternationalizationTemplateMethodModel.java
@@ -36,6 +36,7 @@ public InternationalizationTemplateMethodModel(final Locale locale,
     }
 
     @Override
+    @SuppressWarnings("rawtypes")
     public TemplateModel exec(final List argumentList) throws TemplateModelException {
 
         if (argumentList.isEmpty()) {
diff --git a/voidframework-template-freemarker/src/main/java/dev/voidframework/template/freemarker/method/ReverseRouteTemplateMethodModel.java b/voidframework-template-freemarker/src/main/java/dev/voidframework/template/freemarker/method/ReverseRouteTemplateMethodModel.java
@@ -31,6 +31,7 @@ public ReverseRouteTemplateMethodModel(final Router router) {
     }
 
     @Override
+    @SuppressWarnings("rawtypes")
     public Object exec(final List argumentList) throws TemplateModelException {
 
         if (argumentList.isEmpty()) {
diff --git a/voidframework-web/src/test/java/dev/voidframework/web/http/routing/RouterTest.java b/voidframework-web/src/test/java/dev/voidframework/web/http/routing/RouterTest.java
@@ -154,6 +154,7 @@ void reverseUrlNoArguments() {
     /**
      * A simple controller.
      */
+    @SuppressWarnings("unused")
     private static final class SampleController {
 
         public Result displayHelloWorld() {

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`package dev.voidframework.core.remoteconfiguration;`
`2`	`2`
`3`	`3`	`import com.typesafe.config.Config;`
	`4`	`+import com.typesafe.config.ConfigException;`
`4`	`5`	`import com.typesafe.config.ConfigFactory;`
`5`	`6`	`import dev.voidframework.core.constant.StringConstants;`
`6`	`7`	`import dev.voidframework.core.exception.RemoteConfigurationException;`
`@@ -69,6 +70,10 @@ public static Config processAllProviders(final Config localConfiguration) {`
`69`	`70`	`}`
`70`	`71`	`}`
`71`	`72`	`}`
	`73`	`+ default -> throw new ConfigException.BadValue(`
	`74`	`+ localConfiguration.origin(),`
	`75`	`+ CONFIGURATION_KEY_REGISTERED_PROVIDERS,`
	`76`	`+ "Must be a single String or a StringList");`
`72`	`77`	`}`
`73`	`78`	`}`
`74`	`79`
Original file line number	Diff line number	Diff line change
`@@ -33,6 +33,7 @@ public ConfigTemplateMethodModel(final Config configuration) {`
`33`	`33`	`}`
`34`	`34`
`35`	`35`	`@Override`
	`36`	`+ @SuppressWarnings("rawtypes")`
`36`	`37`	`public TemplateModel exec(final List argumentList) throws TemplateModelException {`
`37`	`38`
`38`	`39`	`if (argumentList.size() != 1) {`
Original file line number	Diff line number	Diff line change
`@@ -36,6 +36,7 @@ public InternationalizationTemplateMethodModel(final Locale locale,`
`36`	`36`	`}`
`37`	`37`
`38`	`38`	`@Override`
	`39`	`+ @SuppressWarnings("rawtypes")`
`39`	`40`	`public TemplateModel exec(final List argumentList) throws TemplateModelException {`
`40`	`41`
`41`	`42`	`if (argumentList.isEmpty()) {`
Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,7 @@ public ReverseRouteTemplateMethodModel(final Router router) {`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`@Override`
	`34`	`+ @SuppressWarnings("rawtypes")`
`34`	`35`	`public Object exec(final List argumentList) throws TemplateModelException {`
`35`	`36`
`36`	`37`	`if (argumentList.isEmpty()) {`