Skip to content

Commit af52499

Browse files
jgebaljgebal
committed
Extended the proftab column size for 12.2 long names
Resolves utPLSQL#716
1 parent f77c987 commit af52499

3 files changed

Lines changed: 17 additions & 17 deletions

File tree

‎source/core/coverage/proftab.sql‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ begin
1212
-- from plsql_profiler_runnumber
1313
related_run number, -- runid of related run (for client/
1414
-- server correlation)
15-
run_owner varchar2(32), -- user who started run
15+
run_owner varchar2(128), -- user who started run
1616
run_date date, -- start time of run
1717
run_comment varchar2(2047), -- user provided comment for this run
1818
run_total_time number, -- elapsed time for this run
@@ -39,9 +39,9 @@ begin
3939
(
4040
runid number references plsql_profiler_runs,
4141
unit_number number, -- internally generated library unit #
42-
unit_type varchar2(32), -- library unit type
43-
unit_owner varchar2(32), -- library unit owner name
44-
unit_name varchar2(32), -- library unit name
42+
unit_type varchar2(128), -- library unit type
43+
unit_owner varchar2(128), -- library unit owner name
44+
unit_name varchar2(128), -- library unit name
4545
-- timestamp on library unit, can be used to detect changes to
4646
-- unit between runs
4747
unit_timestamp date,

‎test/core/reporters/test_coverage/test_html_extended_reporter.pkb‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,15 @@ create or replace package body test_html_extended_reporter is
77
l_charset varchar2(100) := 'ISO-8859-1';
88
begin
99
--Arrange
10-
l_expected := '%<meta %charset='||l_charset||'" />%<h3>UT3.DUMMY_COVERAGE</h3>%<b>4</b> relevant lines. <span class="green"><b>3</b> lines covered</span> (including <span class="yellow"><b>1</b> lines partially covered</span> ) and <span class="red"><b>1</b> lines missed%';
10+
l_expected := '%<meta %charset='||l_charset||'" />%<h3>UT3.DUMMY_COVERAGE_PACKAGE_WITH_AN_AMAZINGLY_LONG_NAME_THAT_YOU_WOULD_NOT_THINK_OF_IN_REAL_LIFE_PROJECT_BECAUSE_ITS_SIMPLY_TOO_LONG</h3>%<b>4</b> relevant lines. <span class="green"><b>3</b> lines covered</span> (including <span class="yellow"><b>1</b> lines partially covered</span> ) and <span class="red"><b>1</b> lines missed%';
1111

1212
select *
1313
bulk collect into l_results
1414
from table(
1515
ut3.ut.run(
1616
a_path => 'ut3.test_dummy_coverage',
1717
a_reporter=> ut3.ut_coverage_html_reporter(),
18-
a_source_files => ut3.ut_varchar2_list( 'test/ut3.dummy_coverage.pkb' ),
18+
a_source_files => ut3.ut_varchar2_list( 'test/ut3.dummy_coverage_package_with_an_amazingly_long_name_that_you_would_not_think_of_in_real_life_project_because_its_simply_too_long.pkb' ),
1919
a_test_files => ut3.ut_varchar2_list( ),
2020
a_client_character_set => l_charset
2121
)

‎test/core/reporters/test_extended_coverage.pkb‎

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@ create or replace package body test_extended_coverage is
2121
procedure create_dummy_coverage_package is
2222
pragma autonomous_transaction;
2323
begin
24-
execute immediate q'[create or replace package UT3.DUMMY_COVERAGE is
24+
execute immediate q'[create or replace package UT3.DUMMY_COVERAGE_PACKAGE_WITH_AN_AMAZINGLY_LONG_NAME_THAT_YOU_WOULD_NOT_THINK_OF_IN_REAL_LIFE_PROJECT_BECAUSE_ITS_SIMPLY_TOO_LONG is
2525
procedure do_stuff(i_input in number);
2626
end;]';
27-
execute immediate q'[create or replace package body UT3.DUMMY_COVERAGE is
27+
execute immediate q'[create or replace package body UT3.DUMMY_COVERAGE_PACKAGE_WITH_AN_AMAZINGLY_LONG_NAME_THAT_YOU_WOULD_NOT_THINK_OF_IN_REAL_LIFE_PROJECT_BECAUSE_ITS_SIMPLY_TOO_LONG is
2828
procedure do_stuff(i_input in number) is
2929
begin
3030
if i_input = 2 then
@@ -49,7 +49,7 @@ create or replace package body test_extended_coverage is
4949
execute immediate q'[create or replace package body UT3.TEST_DUMMY_COVERAGE is
5050
procedure test_do_stuff is
5151
begin
52-
dummy_coverage.do_stuff(1);
52+
dummy_coverage_package_with_an_amazingly_long_name_that_you_would_not_think_of_in_real_life_project_because_its_simply_too_long.do_stuff(1);
5353
ut.expect(1).to_equal(1);
5454
end;
5555
end;]';
@@ -62,7 +62,7 @@ create or replace package body test_extended_coverage is
6262
values(a_run_id, user, sysdate, 'unit testing utPLSQL');
6363

6464
insert into dbmspcc_units ( run_id, object_id, type, owner, name,last_ddl_time)
65-
values(a_run_id, c_unit_id, 'PACKAGE BODY', 'UT3', 'DUMMY_COVERAGE',sysdate);
65+
values(a_run_id, c_unit_id, 'PACKAGE BODY', 'UT3', 'DUMMY_COVERAGE_PACKAGE_WITH_AN_AMAZINGLY_LONG_NAME_THAT_YOU_WOULD_NOT_THINK_OF_IN_REAL_LIFE_PROJECT_BECAUSE_ITS_SIMPLY_TOO_LONG',sysdate);
6666

6767
insert into dbmspcc_blocks ( run_id, object_id, line,block,col,covered,not_feasible)
6868
select a_run_id, c_unit_id,4,1,1,1,0 from dual union all
@@ -78,7 +78,7 @@ create or replace package body test_extended_coverage is
7878
values(a_run_id, user, sysdate, 'unit testing utPLSQL');
7979

8080
insert into ut3.plsql_profiler_units ( runid, unit_number, unit_type, unit_owner, unit_name)
81-
values(a_run_id, c_unit_id, 'PACKAGE BODY', 'UT3', 'DUMMY_COVERAGE');
81+
values(a_run_id, c_unit_id, 'PACKAGE BODY', 'UT3', 'DUMMY_COVERAGE_PACKAGE_WITH_AN_AMAZINGLY_LONG_NAME_THAT_YOU_WOULD_NOT_THINK_OF_IN_REAL_LIFE_PROJECT_BECAUSE_ITS_SIMPLY_TOO_LONG');
8282

8383
insert into ut3.plsql_profiler_data ( runid, unit_number, line#, total_occur, total_time)
8484
select a_run_id, c_unit_id, 4, 1, 1 from dual union all
@@ -104,7 +104,7 @@ create or replace package body test_extended_coverage is
104104
pragma autonomous_transaction;
105105
begin
106106
begin execute immediate q'[drop package ut3.test_dummy_coverage]'; exception when others then null; end;
107-
begin execute immediate q'[drop package ut3.dummy_coverage]'; exception when others then null; end;
107+
begin execute immediate q'[drop package ut3.dummy_coverage_package_with_an_amazingly_long_name_that_you_would_not_think_of_in_real_life_project_because_its_simply_too_long]'; exception when others then null; end;
108108
delete from dbmspcc_blocks where run_id = g_run_id(ut3.ut_coverage.gc_block_coverage);
109109
delete from dbmspcc_units where run_id = g_run_id(ut3.ut_coverage.gc_block_coverage);
110110
delete from dbmspcc_runs where run_id = g_run_id(ut3.ut_coverage.gc_block_coverage);
@@ -120,15 +120,15 @@ create or replace package body test_extended_coverage is
120120
l_results ut3.ut_varchar2_list;
121121
begin
122122
--Arrange
123-
l_expected := '%<file path="ut3.dummy_coverage">%<lineToCover lineNumber="4" covered="true" branchesToCover="2" coveredBranches="1"/>%';
123+
l_expected := '%<file path="ut3.dummy_coverage_package_with_an_amazingly_long_name_that_you_would_not_think_of_in_real_life_project_because_its_simply_too_long">%<lineToCover lineNumber="4" covered="true" branchesToCover="2" coveredBranches="1"/>%';
124124
--Act
125125
select *
126126
bulk collect into l_results
127127
from table(
128128
ut3.ut.run(
129129
a_path => 'ut3.test_dummy_coverage',
130130
a_reporter=> ut3.ut_coverage_sonar_reporter( ),
131-
a_include_objects => ut3.ut_varchar2_list( 'ut3.dummy_coverage' )
131+
a_include_objects => ut3.ut_varchar2_list( 'ut3.dummy_coverage_package_with_an_amazingly_long_name_that_you_would_not_think_of_in_real_life_project_because_its_simply_too_long' )
132132
)
133133
);
134134
--Assert
@@ -142,7 +142,7 @@ create or replace package body test_extended_coverage is
142142
l_results ut3.ut_varchar2_list;
143143
begin
144144
--Arrange
145-
l_expected := '%<file path="ut3.dummy_coverage">%<lineToCover lineNumber="4" covered="true" branchesToCover="2" coveredBranches="1"/>%';
145+
l_expected := '%<file path="ut3.dummy_coverage_package_with_an_amazingly_long_name_that_you_would_not_think_of_in_real_life_project_because_its_simply_too_long">%<lineToCover lineNumber="4" covered="true" branchesToCover="2" coveredBranches="1"/>%';
146146
--Act
147147
select *
148148
bulk collect into l_results
@@ -163,10 +163,10 @@ create or replace package body test_extended_coverage is
163163
l_expected clob;
164164
l_actual clob;
165165
l_results ut3.ut_varchar2_list;
166-
l_file_path varchar2(100);
166+
l_file_path varchar2(250);
167167
begin
168168
--Arrange
169-
l_file_path := lower('test/ut3.dummy_coverage.pkb');
169+
l_file_path := lower('test/ut3.dummy_coverage_package_with_an_amazingly_long_name_that_you_would_not_think_of_in_real_life_project_because_its_simply_too_long.pkb');
170170
l_expected := '%<file path="'||l_file_path||'">%<lineToCover lineNumber="4" covered="true" branchesToCover="2" coveredBranches="1"/>%';
171171
--Act
172172
select *

0 commit comments

Comments
 (0)