Skip to content

refactor: remove the need for "processSourceMap" - #18187

Merged
patak-cat merged 3 commits into
vitejs:mainfrom
sheremet-va:refactor/move-offset-to-evaluator
Sep 24, 2024
Merged

refactor: remove the need for "processSourceMap"#18187
patak-cat merged 3 commits into
vitejs:mainfrom
sheremet-va:refactor/move-offset-to-evaluator

Conversation

@sheremet-va

@sheremet-va sheremet-va commented Sep 24, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Description

This PR move the logic that fixes the source maps in the module runner to the evaluator.

The evaluator is the reason why we need this change, so it makes sense that it will the one controlling it.

@bolt-new-by-stackblitz

bolt-new-by-stackblitz Bot commented Sep 24, 2024

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

patak-cat
patak-cat previously approved these changes Sep 24, 2024
View reviewed changes
@patak-cat

patak-cat commented Sep 24, 2024

Copy link
Copy Markdown
Member

/ecosystem-ci run

@vite-ecosystem-ci

vite-ecosystem-ci Bot commented Sep 24, 2024

Copy link
Copy Markdown

📝 Ran ecosystem CI on 288fc64: Open

suite result latest scheduled
histoire ❌ failure ❌ failure
redwoodjs ❌ failure ✅ success
remix ❌ failure ❌ failure
vike ❌ failure ❌ failure
vite-environment-examples ❌ failure ✅ success

✅ analogjs, astro, ladle, laravel, marko, nuxt, previewjs, quasar, qwik, rakkas, storybook, sveltekit, unocss, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress, vitest, vuepress

sheremet-va
sheremet-va commented Sep 24, 2024
View reviewed changes
Comment thread packages/vite/src/node/ssr/fetchModule.ts Resolved
@patak-cat

patak-cat commented Sep 24, 2024

Copy link
Copy Markdown
Member

/ecosystem-ci run

@vite-ecosystem-ci

vite-ecosystem-ci Bot commented Sep 24, 2024

Copy link
Copy Markdown

📝 Ran ecosystem CI on 584869a: Open

suite result latest scheduled
histoire ❌ failure ❌ failure
remix ❌ failure ❌ failure
vike ❌ failure ❌ failure
vitest ❌ failure ✅ success

✅ analogjs, astro, ladle, laravel, marko, nuxt, previewjs, quasar, qwik, rakkas, redwoodjs, storybook, sveltekit, unocss, vite-environment-examples, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress, vuepress

@vite-ecosystem-ci

vite-ecosystem-ci Bot commented Sep 24, 2024

Copy link
Copy Markdown

📝 Ran ecosystem CI on 584869a: Open

suite result latest scheduled
histoire ❌ failure ❌ failure
remix ❌ failure ❌ failure
vike ❌ failure ❌ failure

✅ analogjs, astro, ladle, laravel, marko, nuxt, previewjs, quasar, qwik, rakkas, redwoodjs, storybook, sveltekit, unocss, vite-environment-examples, vite-plugin-pwa, vite-plugin-react, vite-plugin-react-swc, vite-plugin-svelte, vite-plugin-vue, vite-setup-catalogue, vitepress, vitest, vuepress

@patak-cat
patak-cat merged commit 08ff233 into vitejs:main Sep 24, 2024
@sheremet-va
sheremet-va deleted the refactor/move-offset-to-evaluator branch September 24, 2024 19:42
@hi-ogawa hi-ogawa mentioned this pull request Sep 28, 2024
Merged
moonlitusun pushed a commit to moonlitusun/vite that referenced this pull request May 25, 2025
@sheremet-va @moonlitusun
refactor: remove the need for "processSourceMap" (vitejs#18187)
08f07c7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patak-cat patak-cat patak-cat approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sheremet-va @patak-cat