Skip to content

Commit b9d1afc

Browse files
committed
Add screenshot for creating PR
1 parent de68a9c commit b9d1afc

2 files changed

Lines changed: 9 additions & 3 deletions

File tree

Week1/MAKEME.md

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ You will be working on the same application during the next three weeks. For eac
8383

8484
> *Reminder*: A fork is like your own copy of a repository, under your own account, of someone else's repository. Read everything about forking and being social on GitHub [here](https://help.github.com/en/articles/fork-a-repo).
8585
>
86-
> We use forks so that we can later on create [Pull Requests](https://help.github.com/en/articles/about-pull-requests). In short, a pull request (PR) is a way to ask the original owner of a repository (where you forked off from) to merge a change that you did on a branch of your local repository, into the original repository.
86+
> We use forks so that you can later on create [Pull Requests](https://help.github.com/en/articles/about-pull-requests). In short, a pull request (PR) is a way to ask the original owner of a repository (where you forked off from) to merge a change that you did on a branch of your local repository, into the original repository.
8787
>
8888
> A big advantage of PR's is that it allows to **compare code** and **give feedback** directly on the code! This is very handy when reviewing homework!
8989
@@ -193,8 +193,14 @@ If the answer is 'yes' to the preceding questions you are ready to follow these
193193
git push -u origin week1
194194
```
195195
196+
This will give you a link that you can follow to immediately create a pull request (see next step).
197+
196198
- [ ] Create a pull request (PR) for your `week1` branch against our class' (Rob's) fork `master` branch.
197199
198-
- [ ] Keep an eye on your notifications: if there are issues with your homework, we'll add comments to your PR. If we don't add comments, that means you've done an excellent job - or we dind't find the time to review it :(.
200+
![Create PR in GitHub](./assets/create_pr.png)
201+
202+
- [ ] Keep an eye on your notifications: if there are issues with your homework, your coach will add comments to your PR. If they don't add comments, that means you've done an excellent job - or they dind't find the time to review it :(.
203+
204+
Note that of course the coach will never actually *merge* your PR.
199205
200-
- [ ] You can always amend your homework by pushing more commits to your branch - they'll be included in the pull request. Do this to resolve any remarks we gave in the comments!
206+
- [ ] You can always amend your homework by pushing more commits to your branch - they'll be included in the pull request automatically, and your coach will be notified. Do this to resolve any remarks your coach gave in the comments!

Week1/assets/create_pr.png

43.3 KB
Loading

0 commit comments

Comments
 (0)