Repository navigation
indentation doesn't work well with HEREDOC strings in erb #361
Description
When writing eruby file and using HEREDOC syntax, the indentation doesn't work that well. This is what vim produces when using default indentation:
<!DOCTYPE html>
<html>
<head>
</title>Foo</title>
</head>
<body>
<%= foo <<~EOF
EOF
%>
</body>
The ending %> is off by one level to the left. I believe it should be like this:
</html>
<!DOCTYPE html>
<html>
<head>
</title>Foo</title>
</head>
<body>
<%= foo <<~EOF
EOF
%>
</body>
</html>
Activity
graywolf commentedon Nov 9, 2017
>in%>, tha highlighted bracket is on second<in<<~EOFwhile it should be on<in<%=. Is this plugin also responsible for it?AndrewRadev commentedon Nov 19, 2017
The indenting thing is a tricky issue. In general, there are two styles that eruby is mostly able to handle:
The mixture of the two doesn't work for a lot of other things:
In the heredoc case, unfortunately, the first format is syntactically invalid, because heredocs expect the end delimiter to be on its own line. Honestly, I wouldn't use a heredoc in ERB for that reason alone, it seems pretty fiddly regarding whitespace. You could use the
%{ }delimiter, and that seems to work well with the closing ERB delimiter:You could also use the second kind of indenting, like this:
I understand that, ideally, putting a closing delimiter at the right indent level should work regardless. It's a difficult problem to fix, though, and I really don't think anybody right now would have the time and energy to put into fixing it. I'll leave this issue open, because it's valid, but I'd recommend you try out a different indentation style.
As for the highlighting, it seems to me like it's built-in and not really customizable.
graywolf commentedon Jan 31, 2018
I'll just switch to
thanks :)