Remove broken s:IsInString check

AndrewRadev · AndrewRadev · commit 4788a08433c3 · 2021-02-03T20:08:23.000+02:00
The variable `line` doesn't really exist, but we've never gotten an
error report, and I can't come up with a valid ruby syntax that actually
hits this clause. The check looks at the end of the line and whether
it's a string or comment, but we already do that in
`s:MultilineStringOrLineComment`.

The issue was discovered on this text:

  Indent tests failed:
  testdir/html.fail
  indent (this) line;

So, a colon on the first line, some text that doesn't end in a
continuation character, and the last line errors out. But I couldn't
come up with a syntactically valid ruby combination that would hit it.
So I removed the check completely.
diff --git a/indent/ruby.vim b/indent/ruby.vim
@@ -642,8 +642,7 @@ function! s:PreviousNotMSL(msl_info) abort
       " TODO (2016-10-07) Wrong/unused? How could it be "1"?
       return indent(info.plnum) - 1
       " If previous line is a continuation return its indent.
-      " TODO: the || s:IsInString() thing worries me a bit.
-    elseif s:Match(info.plnum, s:non_bracket_continuation_regex) || s:IsInString(info.plnum, strlen(line))
+    elseif s:Match(info.plnum, s:non_bracket_continuation_regex)
       return indent(info.plnum)
     endif
   endif
